Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2 server + fast reload page #21560

Closed
ariran5 opened this issue Jun 27, 2018 · 2 comments
Closed

http2 server + fast reload page #21560

ariran5 opened this issue Jun 27, 2018 · 2 comments
Labels
http2 Issues or PRs related to the http2 subsystem.

Comments

@ariran5
Copy link

ariran5 commented Jun 27, 2018

  • Version: 10.5.0
  • Platform: Mac 10.13.4

press and hold cmd + r for fast reload page

safari

node[32149]: ../src/node_file.cc:221:MaybeLocal<v8::Promise> node::fs::FileHandle::ClosePromise(): Assertion `!reading_' failed.
 1: 0x100033c31 node::Abort() [/usr/local/bin/node]
 2: 0x100032c77 node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, char const*, int, v8::Local<v8::Value>*, node::async_context) [/usr/local/bin/node]
 3: 0x100069f57 node::fs::FileHandle::ClosePromise() [/usr/local/bin/node]
 4: 0x10005b210 node::fs::FileHandle::Close(v8::FunctionCallbackInfo<v8::Value> const&) [/usr/local/bin/node]
 5: 0x10022822f v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo*) [/usr/local/bin/node]
 6: 0x100227771 v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/usr/local/bin/node]
 7: 0x100226dc0 v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/usr/local/bin/node]
 8: 0xf163cc841bd 
Abort trap: 6

and chrome

node[32161]: ../src/node_http2.cc:1971:virtual int node::http2::Http2Stream::DoWrite(node::WriteWrap *, uv_buf_t *, size_t, uv_stream_t *): Assertion `!this->IsDestroyed()' failed.
 1: 0x100033c31 node::Abort() [/usr/local/bin/node]
 2: 0x100032c77 node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, char const*, int, v8::Local<v8::Value>*, node::async_context) [/usr/local/bin/node]
 3: 0x100072fff node::http2::Http2Stream::DoWrite(node::WriteWrap*, uv_buf_t*, unsigned long, uv_stream_s*) [/usr/local/bin/node]
 4: 0x100073019 non-virtual thunk to node::http2::Http2Stream::DoWrite(node::WriteWrap*, uv_buf_t*, unsigned long, uv_stream_s*) [/usr/local/bin/node]
 5: 0x10007e4ea node::StreamBase::Write(uv_buf_t*, unsigned long, uv_stream_s*, v8::Local<v8::Object>) [/usr/local/bin/node]
 6: 0x1000b7e3f node::StreamPipe::ProcessData(unsigned long, uv_buf_t const&) [/usr/local/bin/node]
 7: 0x1000b7d59 node::StreamPipe::ReadableListener::OnStreamRead(long, uv_buf_t const&) [/usr/local/bin/node]
 8: 0x100069abf node::fs::FileHandle::ReadStart()::$_0::__invoke(uv_fs_s*) [/usr/local/bin/node]
 9: 0x10094fb60 uv__work_done [/usr/local/bin/node]
10: 0x100951ada uv__async_io [/usr/local/bin/node]
11: 0x1009616c5 uv__io_poll [/usr/local/bin/node]
12: 0x100951f4d uv_run [/usr/local/bin/node]
13: 0x10003cb66 node::Start(v8::Isolate*, node::IsolateData*, int, char const* const*, int, char const* const*) [/usr/local/bin/node]
14: 0x10003c38a node::Start(uv_loop_s*, int, char const* const*, int, char const* const*) [/usr/local/bin/node]
15: 0x10003becd node::Start(int, char**) [/usr/local/bin/node]
16: 0x100001034 start [/usr/local/bin/node]
Abort trap: 6
@addaleax addaleax added the http2 Issues or PRs related to the http2 subsystem. label Jun 27, 2018
@addaleax
Copy link
Member

I think this is the same issue as #20824 :/

@ariran5
Copy link
Author

ariran5 commented Jun 27, 2018

I turned off server push and I have this problem

addaleax added a commit to addaleax/node that referenced this issue Jul 15, 2018
targos pushed a commit that referenced this issue Jul 16, 2018
PR-URL: #21561
Fixes: #20824
Fixes: #21560
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants