Can haz V8 upgrade on master to 4.2.77.21 please?

[rvagg]

We've been on 4.2.77.20 since v2.0.1 but that tag doesn't even exist in the V8 repo (anymore?), it just skips from 19 to 21 in the 4.2.77 line. Would someone mine giving us a PR that brings in 4.2.77.21 including any floating patches we have on V8 (the UTF-8 overflow bug is probably a floating patch on master at least).

I have no idea what the difference are btw.

[targos]

👍

4.2.77.21 fixes a weird bug:

var test = function() {
    var a = {"1": false, "2": false, "3": false, "4": false};
    console.log(a[1]);
    a[1] = true;
};
test(); //logs false
test(); //logs false
test(); //logs true

[ofrobots]

Working on it. I am not sure why the tag 4.2.77.20 doesn't exist anymore (or if it ever existed), but for posterity, it should correspond to the commit 5a89bfc68e6054b1092cc6aab5bd8ae23d9e0809 in the V8 repo, https://codereview.chromium.org/1129843002.

[ofrobots]

Landed in 0a7bf81.

[rvagg]

@ofrobots @domenic @bnoordhuis @indutny can you come up with an appropriate person to ping about the missing tag? It's useful for tooling to be able to reference the exact version that we ship with. I actually found this when I was generating some doxygen docs but couldn't find the tag for the 2.4.0 version.

[bnoordhuis]

@rvagg 4.2.77.20 came from the branch-heads/4.2 branch, commit v8/v8@5a89bfc as @ofrobots pointed out. You need to check out the repo with fetch v8 from depot_tools in order to get the branch-heads.

Filed an issue for the missing tag: https://code.google.com/p/v8/issues/detail?id=4322