net: Create socket and immediately destroy throws AssertionError

[feross]

Starting in v2.3.2, this code which used to work, started to throw an AssertionError:

var net = require('net')

var socket = net.connect(5000, '1.1.1.1') // nothing listening on this address
socket.on('error', function (err) {
  console.log('caught error' + err.message)
})
socket.destroy()

With the following exception:

assert.js:89
  throw new assert.AssertionError({
        ^
AssertionError: false == true
    at connect (net.js:778:10)
    at net.js:930:7
    at doNTCallback0 (node.js:408:9)
    at process._tickCallback (node.js:337:13)
    at Function.Module.runMain (module.js:473:11)
    at startup (node.js:117:18)
    at node.js:948:3

I traced the issue back to this PR by @evanlucas, reviewed by @trevnorris and @cjihrig: #2054

[evanlucas]

Ah found it. PR coming shortly

[feross]

Maybe consider adding a test as well, so there's no regression?

[evanlucas]

Yep, added one. Thanks for the report

[feross]

Heh, looks like there are two PRs out now :)

[cjihrig]

Whoops

[trevnorris]

My bad. Didn't take into account a user manually destroying the connection before the connection had completed.

[evanlucas]

Fixed in 503b089.