Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky: test-net-connect-options-port #23207

Closed
refack opened this issue Oct 1, 2018 · 9 comments · Fixed by sthagen/nodejs-node#22
Closed

flaky: test-net-connect-options-port #23207

refack opened this issue Oct 1, 2018 · 9 comments · Fixed by sthagen/nodejs-node#22
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. net Issues and PRs related to the net subsystem.

Comments

@refack
Copy link
Contributor

refack commented Oct 1, 2018

https://ci.nodejs.org/job/node-test-commit-linux/nodes=alpine-last-latest-x64/22004/

timeout

https://ci.nodejs.org/job/node-test-commit-plinux/20584/

timeout
@refack refack added net Issues and PRs related to the net subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Oct 1, 2018
@refack refack mentioned this issue Oct 1, 2018
Merged
3 tasks
@Trott
Copy link
Member

Trott commented Oct 7, 2018

Also Windows:

https://ci.nodejs.org/job/node-test-binary-windows/20561/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=1/console

02:28:41 not ok 327 parallel/test-net-connect-options-port # TODO : Fix flaky test
02:28:41   ---
02:28:41   duration_ms: 120.74
02:28:41   severity: fail
02:28:41   exitcode: 1
02:28:41   stack: |-
02:28:41     timeout
02:28:41   ...

@Trott
Copy link
Member

Trott commented Oct 7, 2018

Stress test: https://ci.nodejs.org/job/node-stress-single-test/2064/

@refack
Copy link
Contributor Author

refack commented Oct 7, 2018

fails in ci.nodejs.org/job/node-stress-single-test/2064
alpine-last-latest-x64 - 29 in 1600
win2008r2-mp-vs2017 - 4 in 1600

@Trott
Copy link
Member

Trott commented Oct 8, 2018 •
edited
Loading

Parameters for stress test were:

RUN_TESTS: -j 8 --repeat 16 parallel/test-net-connect-options-port
RUN_TIMES: 100

@Trott
Copy link
Member

Trott commented Oct 11, 2018

Running stress test again in case the libuv upgrade or something else might fix this:

https://ci.nodejs.org/job/node-stress-single-test/2066/

@refack refack mentioned this issue Jun 7, 2019
Open
@Trott
Copy link
Member

Trott commented Jun 14, 2019

Running stress test again in case the libuv upgrade or something else might fix this:

https://ci.nodejs.org/job/node-stress-single-test/2066/

I'm guessing I forgot to circle back and check those results, and now they're long gone. But I haven't seen this in a while, I don't think, so let's see...

https://ci.nodejs.org/job/node-stress-single-test/2227/ (queued)

Parameters are as above.

@BridgeAR
Copy link
Member

Just checking if this is still flaky: https://ci.nodejs.org/job/node-stress-single-test/61/

@Trott
Copy link
Member

Trott commented Feb 18, 2020

Just checking if this is still flaky: https://ci.nodejs.org/job/node-stress-single-test/61/

CI is green. Looks like we can unmark the test and close this issue.

@Trott Trott mentioned this issue Feb 18, 2020
Closed
2 tasks
@Trott
Copy link
Member

Trott commented Feb 18, 2020

#31841

@Trott Trott closed this as completed in cdac185 Feb 20, 2020
@sthagen sthagen mentioned this issue Feb 20, 2020
Merged
4 tasks
codebytere pushed a commit that referenced this issue Feb 27, 2020
@Trott @codebytere
test: remove flaky designation for test-net-connect-options-port
7d5776e 
Closes: #23207

PR-URL: #31841
Fixes: #23207
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
codebytere pushed a commit that referenced this issue Mar 15, 2020
@Trott @codebytere
test: remove flaky designation for test-net-connect-options-port
86cd207 
Closes: #23207

PR-URL: #31841
Fixes: #23207
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
codebytere pushed a commit that referenced this issue Mar 17, 2020
@Trott @codebytere
test: remove flaky designation for test-net-connect-options-port
58b2f86 
Closes: #23207

PR-URL: #31841
Fixes: #23207
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
codebytere pushed a commit that referenced this issue Mar 30, 2020
@Trott @codebytere
test: remove flaky designation for test-net-connect-options-port
bde5a9b 
Closes: #23207

PR-URL: #31841
Fixes: #23207
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
3 participants
@refack @Trott @BridgeAR