Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky: test-gc-http-client-connaborted #23219

Closed
refack opened this issue Oct 2, 2018 · 0 comments
Closed

flaky: test-gc-http-client-connaborted #23219

refack opened this issue Oct 2, 2018 · 0 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. v8 engine Issues and PRs related to the V8 dependency.

Comments

@refack
Copy link
Contributor

refack commented Oct 2, 2018 •
edited
Loading

Seen 8 times in sequential and 8 times in parallel between 2018-09-27 to 2018-10-02 nodejs/reliability#18

timeout

Seem stuck after 495/500
https://ci.nodejs.org/job/node-test-commit-linux/21933/nodes=alpine-last-latest-x64/testReport/junit/(root)/test/parallel_test_gc_http_client_connaborted/
@refack refack added http Issues or PRs related to the http subsystem. v8 engine Issues and PRs related to the V8 dependency. test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Oct 2, 2018
@refack refack mentioned this issue Oct 2, 2018
Merged
3 tasks
addaleax added a commit to addaleax/libuv that referenced this issue Oct 4, 2018
@addaleax
unix,win: fix threadpool race condition
28139bf 
90891b4 introduced a race
condition when accessing `slow_io_work_running` – it is being
increased and later decreased as part of the worker thread loop,
but was accessed with different mutexes during these operations.

This fixes the race condition by making sure both accesses
are protected through the global `mutex` of `threadpool.c`.

This fixes a number of flaky Node.js tests.

Refs: libuv#1845
Refs: nodejs/reliability#18
Refs: nodejs/node#23089
Refs: nodejs/node#23067
Refs: nodejs/node#23066
Refs: nodejs/node#23219
@addaleax addaleax mentioned this issue Oct 4, 2018
Closed
addaleax added a commit to addaleax/node that referenced this issue Oct 4, 2018
@addaleax
unix,win: fix threadpool race condition
68c81b9 
90891b4232e91dbd7a2e2077e4d23d16a374b41d introduced a race
condition when accessing `slow_io_work_running` – it is being
increased and later decreased as part of the worker thread loop,
but was accessed with different mutexes during these operations.

This fixes the race condition by making sure both accesses
are protected through the global `mutex` of `threadpool.c`.

This fixes a number of flaky Node.js tests.

Refs: libuv/libuv#1845
Refs: nodejs/reliability#18
Refs: nodejs#23089
Refs: nodejs#23067
Refs: nodejs#23066
Refs: nodejs#23219
addaleax added a commit to libuv/libuv that referenced this issue Oct 7, 2018
@addaleax
unix,win: fix threadpool race condition
daf04e8 
90891b4 introduced a race
condition when accessing `slow_io_work_running` – it is being
increased and later decreased as part of the worker thread loop,
but was accessed with different mutexes during these operations.

This fixes the race condition by making sure both accesses
are protected through the global `mutex` of `threadpool.c`.

This fixes a number of flaky Node.js tests.

Refs: #1845
Refs: nodejs/reliability#18
Refs: nodejs/node#23089
Refs: nodejs/node#23067
Refs: nodejs/node#23066
Refs: nodejs/node#23219
PR-URL: #2021
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
cjihrig added a commit to cjihrig/node that referenced this issue Oct 8, 2018
@cjihrig
deps: upgrade to libuv 1.23.2
8d645ef 
Fixes: nodejs#23043
Fixes: nodejs#21773
Fixes: nodejs#16601
Fixes: nodejs#22999
Fixes: nodejs#23219
Fixes: nodejs#23066
Fixes: nodejs#23067
Fixes: nodejs#23089
@cjihrig cjihrig mentioned this issue Oct 8, 2018
Closed
4 tasks
@Trott Trott closed this as completed in c65a523 Oct 9, 2018
targos pushed a commit that referenced this issue Oct 10, 2018
@cjihrig @targos
deps: upgrade to libuv 1.23.2
76cb52c 
PR-URL: #23336
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Fixes: #23043
Fixes: #21773
Fixes: #16601
Fixes: #22999
Fixes: #23219
Fixes: #23066
Fixes: #23067
Fixes: #23089
jasnell pushed a commit that referenced this issue Oct 17, 2018
@cjihrig @jasnell
deps: upgrade to libuv 1.23.2
f9d79ea 
PR-URL: #23336
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Fixes: #23043
Fixes: #21773
Fixes: #16601
Fixes: #22999
Fixes: #23219
Fixes: #23066
Fixes: #23067
Fixes: #23089
MylesBorins pushed a commit to MylesBorins/node that referenced this issue Nov 5, 2018
@cjihrig @MylesBorins
deps: upgrade to libuv 1.23.2
437f4fc 
PR-URL: nodejs#23336
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Fixes: nodejs#23043
Fixes: nodejs#21773
Fixes: nodejs#16601
Fixes: nodejs#22999
Fixes: nodejs#23219
Fixes: nodejs#23066
Fixes: nodejs#23067
Fixes: nodejs#23089
MylesBorins pushed a commit that referenced this issue Nov 11, 2018
@cjihrig @MylesBorins
deps: upgrade to libuv 1.23.2
62dd1d7 
Backport-PR-URL: #24103
PR-URL: #23336
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Fixes: #23043
Fixes: #21773
Fixes: #16601
Fixes: #22999
Fixes: #23219
Fixes: #23066
Fixes: #23067
Fixes: #23089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: upgrade to libuv 1.23.2 cjihrig/node
1 participant
@refack