Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test-tls-set-secure-context #23807

Closed
targos opened this issue Oct 21, 2018 · 1 comment
Closed

Investigate flaky test-tls-set-secure-context #23807

targos opened this issue Oct 21, 2018 · 1 comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. tls Issues and PRs related to the tls subsystem.

Comments

@targos
Copy link
Member

targos commented Oct 21, 2018

  • Version: master
  • Platform: linuxone, ubuntu1604 (shared lib)
  • Subsystem: tls

The test was just added today in #23644

https://ci.nodejs.org/job/node-test-pull-request/18030/

12:55:25 not ok 2352 parallel/test-tls-set-secure-context
12:55:25   ---
12:55:25   duration_ms: 120.93
12:55:25   severity: fail
12:55:25   exitcode: -15
12:55:25   stack: |-
12:55:25     timeout
12:55:25   ...
@targos targos added tls Issues and PRs related to the tls subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Oct 21, 2018
@targos targos mentioned this issue Oct 21, 2018
Merged
2 tasks
@cjihrig cjihrig mentioned this issue Oct 21, 2018
Closed
3 tasks
@cjihrig
Copy link
Contributor

cjihrig commented Oct 21, 2018

Proposed fix in #23811. Sorry for breaking things.

@refack refack mentioned this issue Oct 23, 2018
Merged
3 tasks
@Trott Trott closed this as completed in b794f58 Oct 24, 2018
targos pushed a commit that referenced this issue Oct 24, 2018
@cjihrig @targos
test: fix flaky test
83ddd3e 
This commit fixes test-tls-set-secure-context.js. The test was
making one long lasting HTTP connection, followed by a number of
shorter lived connections. However, it was possible that the
connections were not received in the desired order. This commit
ensures that the long lasting connection is established before
making any other connections.

PR-URL: #23811
Fixes: #23807
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@bnoordhuis bnoordhuis mentioned this issue Oct 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky test cjihrig/node
2 participants
@targos @cjihrig