Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate flaky parallel/test-worker-cleanup-handles #24005

Closed
Trott opened this issue Oct 31, 2018 · 3 comments
Closed

investigate flaky parallel/test-worker-cleanup-handles #24005

Trott opened this issue Oct 31, 2018 · 3 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform. worker Issues and PRs related to Worker support.

Comments

@Trott
Copy link
Member

Trott commented Oct 31, 2018

https://ci.nodejs.org/job/node-test-binary-windows/21154/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=1/console on test-rackspace-win2008r2-x64-4

00:05:32 not ok 523 parallel/test-worker-cleanup-handles
00:05:32   ---
00:05:32   duration_ms: 120.100
00:05:32   severity: fail
00:05:32   exitcode: 1
00:05:32   stack: |-
00:05:32     timeout
00:05:32   ...
@Trott Trott added windows Issues and PRs related to the Windows platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. worker Issues and PRs related to Worker support. labels Oct 31, 2018
@Trott Trott mentioned this issue Oct 31, 2018
Closed
@Trott
Copy link
Member Author

Trott commented Nov 4, 2018

@nodejs/workers

@bnoordhuis bnoordhuis mentioned this issue Jan 7, 2019
Closed
2 tasks
@bnoordhuis
Copy link
Member

Still happens occasionally, see e.g. this run.

@Trott
Copy link
Member Author

Trott commented Jan 7, 2019

https://ci.nodejs.org/job/node-test-binary-windows/22891/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=1/console

test-rackspace-win2008r2-x64-6

11:08:41 not ok 527 parallel/test-worker-cleanup-handles
11:08:41   ---
11:08:41   duration_ms: 120.106
11:08:41   severity: fail
11:08:41   exitcode: 1
11:08:41   stack: |-
11:08:41     timeout
11:08:41   ...

@addaleax addaleax mentioned this issue Jan 31, 2019
Closed
addaleax added a commit to addaleax/node that referenced this issue Feb 3, 2019
@addaleax
worker,etw: only enable ETW on the main thread
b8624ab 
The Windows ETW code is not written to be compatible with multi-threading,
and in particular it relies on global state like a single static
`uv_async_t`. Adding that to multiple threads would corrupt the
corresponding loops' handle queues.

This addresses the flakiness of at least `test-worker-exit-code` and
very likely other flaky tests that relate to Worker threads on Windows as well.

Fixes: nodejs#25847
Fixes: nodejs#25702
Fixes: nodejs#24005
Fixes: nodejs#23873
@addaleax addaleax mentioned this issue Feb 3, 2019
Closed
2 tasks
addaleax added a commit that referenced this issue Feb 6, 2019
@addaleax
worker,etw: only enable ETW on the main thread
c959d60 
The Windows ETW code is not written to be compatible with multi
threading, and in particular it relies on global state like a
single static `uv_async_t`. Adding that to multiple threads
would corrupt the corresponding loops' handle queues.

This addresses the flakiness of at least
`test-worker-exit-code` and very likely other flaky tests that
relate to Worker threads on Windows as well.

Fixes: #25847
Fixes: #25702
Fixes: #24005
Fixes: #23873

PR-URL: #25907
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

worker,etw: only enable ETW on the main thread addaleax/node
2 participants
@bnoordhuis @Trott