Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Agent ctor options are not fully documented, such as lookup #24098

Closed
bitinn opened this issue Nov 5, 2018 · 4 comments
Closed

Doc: Agent ctor options are not fully documented, such as lookup #24098

bitinn opened this issue Nov 5, 2018 · 4 comments
Labels
doc Issues and PRs related to the documentations. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. http Issues or PRs related to the http subsystem.

Comments

@bitinn
Copy link

bitinn commented Nov 5, 2018 •
edited
Loading

ref:

issue:
This was referenced Nov 5, 2018
Closed
Closed
@sam-github
Copy link
Contributor

sam-github commented Nov 5, 2018 •
edited
Loading

Agreed, if the options are passed to net.connect (EDIT: sorry, socket.connect()), the docs should say so. Can you PR a fix?

@bitinn
Copy link
Author

bitinn commented Nov 5, 2018

@sam-github I will take a look at doc style guide and see what I can do.

@Trott Trott added the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Nov 21, 2018
@nanomosfet
Copy link
Contributor

@Trott I can take a spin at this if thats okay. I think we just need to look at the socket.connect() options docs/code and add that into our Agent docs. Does that seem about right?

@BeniCheni BeniCheni mentioned this issue Dec 5, 2018
Closed
4 tasks
@bitinn bitinn mentioned this issue Dec 8, 2018
Closed
Trott pushed a commit to Trott/io.js that referenced this issue Dec 8, 2018
@BeniCheni @Trott
doc: update http doc for new Agent()/support options in socket.connect()
22564b9 
For new Agent() signature in http doc, list the supported options in
socket.connect().

Refs: nodejs#24098

PR-URL: nodejs#24846
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this issue Dec 17, 2018
@BeniCheni @BethGriggs
doc: update http doc for new Agent()/support options in socket.connect()
81dce68 
For new Agent() signature in http doc, list the supported options in
socket.connect().

Refs: #24098

PR-URL: #24846
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
@BeniCheni @refack
doc: update http doc for new Agent()/support options in socket.connect()
f073cda 
For new Agent() signature in http doc, list the supported options in
socket.connect().

Refs: nodejs#24098

PR-URL: nodejs#24846
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this issue Feb 12, 2019
@BeniCheni @BethGriggs
doc: update http doc for new Agent()/support options in socket.connect()
a7f36dd 
For new Agent() signature in http doc, list the supported options in
socket.connect().

Refs: #24098

PR-URL: #24846
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this issue Feb 20, 2019
@BeniCheni @BethGriggs
doc: update http doc for new Agent()/support options in socket.connect()
e566bdc 
For new Agent() signature in http doc, list the supported options in
socket.connect().

Refs: #24098

PR-URL: #24846
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg pushed a commit that referenced this issue Feb 28, 2019
@BeniCheni @rvagg
doc: update http doc for new Agent()/support options in socket.connect()
478c191 
For new Agent() signature in http doc, list the supported options in
socket.connect().

Refs: #24098

PR-URL: #24846
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@jasnell jasnell added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Jun 26, 2020
@jasnell
Copy link
Member

jasnell commented Jul 6, 2020

This appears to have been fixed but never closed.

@jasnell jasnell closed this as completed Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sam-github @jasnell @Trott @bitinn @nanomosfet