Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominating @antsmartian as a Collaborator #24340

Closed
Trott opened this issue Nov 13, 2018 · 10 comments
Closed

Nominating @antsmartian as a Collaborator #24340

Trott opened this issue Nov 13, 2018 · 10 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@Trott
Copy link
Member

Trott commented Nov 13, 2018

I'd like to nominate @antsmartian to be a Collaborator. They've done a solid chunk of useful work and have been an active and positive presence in the issue tracker.

Commits: https://github.com/nodejs/node/commits?author=antsmartian
Open PRs: https://github.com/nodejs/node/pulls/antsmartian

@Trott Trott added meta Issues and PRs related to the general management of the project. abandoned and removed abandoned labels Nov 13, 2018
@Trott
Copy link
Member Author

Trott commented Nov 13, 2018

I think we're supposed to ping @nodejs/collaborators on these things so there you go...

@antsmartian
Copy link
Contributor

@Trott : Thanks much. I love contributing to Node.js :)

@trivikr
Copy link
Member

trivikr commented Nov 13, 2018

+1

3 similar comments
@thefourtheye
Copy link
Contributor

+1

@BridgeAR
Copy link
Member

+1

@cjihrig
Copy link
Contributor

cjihrig commented Nov 13, 2018

+1

@cfanoulis
Copy link
Contributor

+1 (not like my opinion is counted, is it?)

@apapirovski
Copy link
Member

+1

2 similar comments
@benjamingr
Copy link
Member

+1

@mhdawson
Copy link
Member

+1

antsmartian added a commit to antsmartian/node that referenced this issue Nov 26, 2018
targos pushed a commit that referenced this issue Nov 28, 2018
Fixes: #24340

PR-URL: #24655
Refs: #24340
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
Fixes: nodejs#24340

PR-URL: nodejs#24655
Refs: nodejs#24340
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
BethGriggs pushed a commit that referenced this issue Feb 12, 2019
Fixes: #24340

PR-URL: #24655
Refs: #24340
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
rvagg pushed a commit that referenced this issue Feb 28, 2019
Fixes: #24340

PR-URL: #24655
Refs: #24340
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

10 participants