Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V8: test-v8 is broken #24393

Closed
refack opened this issue Nov 16, 2018 · 13 comments · Fixed by #24394
Closed

V8: test-v8 is broken #24393

refack opened this issue Nov 16, 2018 · 13 comments · Fixed by #24394
Labels
regression Issues related to regressions. v8 engine Issues and PRs related to the V8 dependency.

Comments

@refack
Copy link
Contributor

refack commented Nov 16, 2018

  • Version: master
  • Platform: several
  • Subsystem: V8

Sometime in the last 75h master broke WRT to our V8 test:
(Nov 13, 2018 5:34:00 AM) 7067572a6355acf14cc89abe210e030e84d0d474 ✔️
(Nov 14, 2018 5:34:00 AM) 0e06b350b6d7c80875321531593efc6f273620e5 ❌
(Nov 15, 2018 5:34:00 AM) 3212f77ac6d674a7d43c3303dcca22508c8be468 ❌
(Nov 16, 2018 5:34:00 AM) 8cdb92f11c79de45ed1e7686717bbfc6df304a05 ❌
@refack refack added v8 engine Issues and PRs related to the V8 dependency. regression Issues related to regressions. labels Nov 16, 2018
@refack
Copy link
Contributor Author

refack commented Nov 16, 2018

/CC @nodejs/v8 @nodejs/v8-update

@targos
Copy link
Member

targos commented Nov 16, 2018

#24274 was landed on Nov 14 despite a red V8 CI.

@refack
Copy link
Contributor Author

refack commented Nov 16, 2018

7067572...0e06b35

@targos
Copy link
Member

targos commented Nov 16, 2018

Error in test compilation:

15:28:41 FAILED: obj/test/cctest/cctest_sources/test-cpu-profiler.o 
15:28:41 ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/test/cctest/cctest_sources/test-cpu-profiler.o.d -DV8_INTL_SUPPORT -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -DCR_CLANG_REVISION=\"338452-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=332543 -DCR_LIBCXXABI_REVISION=331450 -DCR_SYSROOT_HASH=815a8c22f8657fe57d02e2c2d893bcdc25a243cf -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DV8_DEPRECATION_WARNINGS -DV8_IMMINENT_DEPRECATION_WARNINGS -DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64 -DENABLE_GDB_JIT_INTERFACE -DENABLE_MINOR_MC -DV8_DEPRECATION_WARNINGS -DV8_IMMINENT_DEPRECATION_WARNINGS -DV8_INTL_SUPPORT -DV8_USE_SNAPSHOT -DV8_USE_EXTERNAL_STARTUP_DATA -DV8_CONCURRENT_MARKING -DV8_EMBEDDED_BUILTINS -DV8_TARGET_ARCH_X64 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -I../.. -Igen -I../../include -Igen/include -I../.. -Igen -I../../include -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -fcomplete-member-pointers -m64 -march=x86-64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-user-defined-warnings -Wno-unused-lambda-capture -Wno-null-pointer-arithmetic -Wno-enum-compare-switch -Wno-ignored-pragma-optimize -fno-omit-frame-pointer -g0 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wmissing-field-initializers -Winconsistent-missing-override -Wunreachable-code -Wshorten-64-to-32 -O3 -fno-ident -fdata-sections -ffunction-sections -std=c++14 -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_sid_amd64-sysroot -fvisibility-inlines-hidden -c ../../test/cctest/test-cpu-profiler.cc -o obj/test/cctest/cctest_sources/test-cpu-profiler.o
15:28:41 ../../test/cctest/test-cpu-profiler.cc:2574:34: error: use of undeclared identifier 'GetSourcePositionEntryCount'
15:28:41     int non_detailed_positions = GetSourcePositionEntryCount(i_isolate, source);
15:28:41                                  ^
15:28:41 ../../test/cctest/test-cpu-profiler.cc:2579:30: error: use of undeclared identifier 'GetSourcePositionEntryCount'
15:28:41     int detailed_positions = GetSourcePositionEntryCount(i_isolate, source);
15:28:41                              ^
15:28:41 2 errors generated.

@refack refack mentioned this issue Nov 16, 2018
Merged
2 tasks
@refack
Copy link
Contributor Author

refack commented Nov 16, 2018

Opened #24394

@Trott
Copy link
Member

Trott commented Nov 16, 2018

Sorry about landing that PR. I saw green CI, approvals, etc. V8 is special and I should have left it to the pros.

@refack
Copy link
Contributor Author

refack commented Nov 16, 2018

[post-mortem]: Jenkins should rediate status of test-v8 jobs to GitHub.

refack added a commit to refack/node that referenced this issue Nov 17, 2018
@refack
Revert "src: enable detailed source positions in V8"
6adbe9a 
This reverts commit e2a8e32.
This reverts commit 715bbb9.

PR-URL: nodejs#24394
Fixes: nodejs#24393
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@refack
Copy link
Contributor Author

refack commented Nov 17, 2018 •
edited
Loading

Post land CI shows a failed test:
mjsunit_wasm_jsapi_harness on ppcle-ubuntu1404

stdout:
/home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps/v8/test/mjsunit/wasm/jsapi-harness.js:102: Error loading file
load("test/wasm-js/test/harness/wasm-constants.js");
^
Command: /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps/v8/out.gn/ppc64.release/d8 --test /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps/v8/test/mjsunit/mjsunit.js /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps/v8/test/mjsunit/wasm/jsapi-harness.js --random-seed=-50650634 --nohard-abort --expose-wasm --allow-natives-syntax

Rerunning: https://ci.nodejs.org/job/node-test-commit-v8-linux/1867/ ❌ (fail repetead in job 1867)

/CC @nodejs/v8 @nodejs/platform-ppc

@refack
Copy link
Contributor Author

refack commented Nov 17, 2018 •
edited
Loading

Bisect CI on 7067572 - https://ci.nodejs.org/job/node-test-commit-v8-linux/1868/

@targos
Copy link
Member

targos commented Nov 17, 2018

Could that be due to a conflict between master and canary? wasm-js isn't gitignored on master so after a canary test run,the files are still there, untracked.

@refack
Copy link
Contributor Author

refack commented Nov 17, 2018 •
edited
Loading

We do a git reset --hard && git clean -xdf so supposedly that should be taken can of.
I just wiped all 4 workspaces, and I'm rerunning LKGR:

Bisect:

  1. CI on 7067572 - https://ci.nodejs.org/job/node-test-commit-v8-linux/1869/ ✔️
  2. CI on 6adbe9a - https://ci.nodejs.org/job/node-test-commit-v8-linux/1870/ ✔️

@refack
Copy link
Contributor Author

refack commented Nov 17, 2018

Could that be due to a conflict between master and canary?

Above bisect seems to indicate that it is.
I'll see how we can do a better cleanup.

@refack
Copy link
Contributor Author

refack commented Nov 17, 2018

So I think I solved the possible conflict issue.
I run the test for canary
https://ci.nodejs.org/job/node-test-commit-v8-linux/1877/ (failed because of nodejs/node-v8#90)
then run master
https://ci.nodejs.org/job/node-test-commit-v8-linux/1878/ ✔️
and it passed, so 🤞 we solved it.

targos pushed a commit that referenced this issue Nov 18, 2018
@refack @targos
Revert "src: enable detailed source positions in V8"
d92bd03 
This reverts commit e2a8e32.
This reverts commit 715bbb9.

PR-URL: #24394
Fixes: #24393
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@refack refack mentioned this issue Nov 18, 2018
Closed
@hashseed hashseed mentioned this issue Nov 20, 2018
Closed
3 tasks
addaleax pushed a commit that referenced this issue Nov 23, 2018
@hashseed @addaleax
deps: cherry-pick 073073b from upstream V8
39db8b1 
Original commit message:

    [profiler] introduce API to enable detailed source positions

    This allows Node.js to enable detailed source positions for optimized code
    early on, without having to pass a flag string.

    R=petermarshall@chromium.org

    Change-Id: Ie74ea41f600cf6e31acbe802116df4976ccf1c75
    Reviewed-on: https://chromium-review.googlesource.com/c/1319757
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57380}

Refs: v8/v8@073073b

PR-URL: #24515
Refs: #24274
Refs: #24394
Refs: #24393
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Peter Marshall <petermarshall@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax pushed a commit that referenced this issue Nov 23, 2018
@hashseed @addaleax
src: enable detailed source positions in V8
12b69f9 
PR-URL: #24515
Refs: #24274
Refs: #24394
Refs: #24393
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Peter Marshall <petermarshall@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this issue Nov 24, 2018
@hashseed @targos
deps: cherry-pick 073073b from upstream V8
0ae44bb 
Original commit message:

    [profiler] introduce API to enable detailed source positions

    This allows Node.js to enable detailed source positions for optimized code
    early on, without having to pass a flag string.

    R=petermarshall@chromium.org

    Change-Id: Ie74ea41f600cf6e31acbe802116df4976ccf1c75
    Reviewed-on: https://chromium-review.googlesource.com/c/1319757
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57380}

Refs: v8/v8@073073b

PR-URL: #24515
Refs: #24274
Refs: #24394
Refs: #24393
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Peter Marshall <petermarshall@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this issue Nov 24, 2018
@hashseed @targos
src: enable detailed source positions in V8
85c1d62 
PR-URL: #24515
Refs: #24274
Refs: #24394
Refs: #24393
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Peter Marshall <petermarshall@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
rvagg pushed a commit that referenced this issue Nov 28, 2018
@refack @rvagg
Revert "src: enable detailed source positions in V8"
a7f6c04 
This reverts commit e2a8e32.
This reverts commit 715bbb9.

PR-URL: #24394
Fixes: #24393
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
rvagg pushed a commit that referenced this issue Nov 28, 2018
@hashseed @rvagg
deps: cherry-pick 073073b from upstream V8
61179e6 
Original commit message:

    [profiler] introduce API to enable detailed source positions

    This allows Node.js to enable detailed source positions for optimized code
    early on, without having to pass a flag string.

    R=petermarshall@chromium.org

    Change-Id: Ie74ea41f600cf6e31acbe802116df4976ccf1c75
    Reviewed-on: https://chromium-review.googlesource.com/c/1319757
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57380}

Refs: v8/v8@073073b

PR-URL: #24515
Refs: #24274
Refs: #24394
Refs: #24393
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Peter Marshall <petermarshall@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
rvagg pushed a commit that referenced this issue Nov 28, 2018
@hashseed @rvagg
src: enable detailed source positions in V8
aa220cf 
PR-URL: #24515
Refs: #24274
Refs: #24394
Refs: #24393
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Peter Marshall <petermarshall@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit to targos/node that referenced this issue Dec 4, 2018
@hashseed @targos
deps: cherry-pick 073073b from upstream V8
cbce4e4 
Original commit message:

    [profiler] introduce API to enable detailed source positions

    This allows Node.js to enable detailed source positions for optimized code
    early on, without having to pass a flag string.

    R=petermarshall@chromium.org

    Change-Id: Ie74ea41f600cf6e31acbe802116df4976ccf1c75
    Reviewed-on: https://chromium-review.googlesource.com/c/1319757
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57380}

Refs: v8/v8@073073b

PR-URL: nodejs#24515
Refs: nodejs#24274
Refs: nodejs#24394
Refs: nodejs#24393
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Peter Marshall <petermarshall@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
pull bot pushed a commit to shakir-abdo/node that referenced this issue Dec 6, 2018
@hashseed @targos
deps: cherry-pick 073073b from upstream V8
d088007 
Original commit message:

    [profiler] introduce API to enable detailed source positions

    This allows Node.js to enable detailed source positions for optimized code
    early on, without having to pass a flag string.

    R=petermarshall@chromium.org

    Change-Id: Ie74ea41f600cf6e31acbe802116df4976ccf1c75
    Reviewed-on: https://chromium-review.googlesource.com/c/1319757
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57380}

Refs: v8/v8@073073b

PR-URL: nodejs#24515
Refs: nodejs#24274
Refs: nodejs#24394
Refs: nodejs#24393
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Peter Marshall <petermarshall@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
@hashseed @refack
deps: cherry-pick 073073b from upstream V8
41f20f0 
Original commit message:

    [profiler] introduce API to enable detailed source positions

    This allows Node.js to enable detailed source positions for optimized code
    early on, without having to pass a flag string.

    R=petermarshall@chromium.org

    Change-Id: Ie74ea41f600cf6e31acbe802116df4976ccf1c75
    Reviewed-on: https://chromium-review.googlesource.com/c/1319757
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57380}

Refs: v8/v8@073073b

PR-URL: nodejs#24515
Refs: nodejs#24274
Refs: nodejs#24394
Refs: nodejs#24393
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Peter Marshall <petermarshall@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
@hashseed @refack
src: enable detailed source positions in V8
c0e6c6a 
PR-URL: nodejs#24515
Refs: nodejs#24274
Refs: nodejs#24394
Refs: nodejs#24393
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Peter Marshall <petermarshall@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
@hashseed @refack
deps: cherry-pick 073073b from upstream V8
7e0ce22 
Original commit message:

    [profiler] introduce API to enable detailed source positions

    This allows Node.js to enable detailed source positions for optimized code
    early on, without having to pass a flag string.

    R=petermarshall@chromium.org

    Change-Id: Ie74ea41f600cf6e31acbe802116df4976ccf1c75
    Reviewed-on: https://chromium-review.googlesource.com/c/1319757
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57380}

Refs: v8/v8@073073b

PR-URL: nodejs#24515
Refs: nodejs#24274
Refs: nodejs#24394
Refs: nodejs#24393
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Peter Marshall <petermarshall@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression Issues related to regressions. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "src: enable detailed source positions in V8" refack/node
3 participants
@refack @Trott @targos