-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-process-active-wraps fails on windows #246
Comments
nodejs/node-v0.x-archive#8989 is a proposed fix. |
@cjihrig Is there any motivation for that revert, other than just to make the test pass. It's quite easy to make the test pass. Just do: That gives the event loop enough time to clean up the TCPWrap object. |
@piscisaureus yes, the revert was done to get everything back to passing. I originally tried adding a The test does pass if I add a |
@cjihrig |
b636ba8 broke this test, because it now takes a loop iteration or two to resolve the loopback address. That consequence is that the TCPWrap handle that we *don't* want to see is created a bit later, and also destroyed later, so when we assert that the active handle list is empty the TCPWrap object is still "busy" being closed. Wait one extra loop iteration before checking there are no more active handles. This allows name resolution and clean-up to finish before the assertion. BUG: #246 PR-URL: nodejs/node-v0.x-archive#8998 Reviewed-By: Bert Belder <bertbelder@gmail.com>
Fixed in b5c9dcb |
Tracked in node: nodejs/node-v0.x-archive#8986
According to @cjihrig:
The problem is likely due to the DNS resolution that's now needed, so net.js postpones TCPWrap creation, now doing it on the same loop turn in which the assertion is done.
The text was updated successfully, but these errors were encountered: