-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChildProcess spawn ignores options param #24912
Comments
2 tasks
eduardbme
added a commit
to eduardbme/node
that referenced
this issue
Dec 16, 2018
spawn method ignores 3-d argument 'options' in case the second one 'args' equals to 'undefined'. Fixes: nodejs#24912
refack
pushed a commit
to refack/node
that referenced
this issue
Jan 14, 2019
spawn method ignores 3-d argument 'options' in case the second one 'args' equals to 'undefined'. Fixes: nodejs#24912 PR-URL: nodejs#24913 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I know how to fix it, just pass an empty array as a second argument, or completely skip it.
But that behavior a little bit weird, the second parameter (args) is optional, so I guessed
undefined
is okay for it.When using TypeScript some IDEs suggests that
undefined
value could be passed (cuz param is optional) and that's why in my project I passedundefined
to it and got a weird program behavior.The text was updated successfully, but these errors were encountered: