Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x] flaky sequential/test-http2-settings-flood #25043

Closed
mcollina opened this issue Dec 14, 2018 · 10 comments
Closed

[v8.x] flaky sequential/test-http2-settings-flood #25043

mcollina opened this issue Dec 14, 2018 · 10 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem.

Comments

@mcollina
Copy link
Member

In a recent CI run there was a crash sequential/test-http2-settings-flood

13:27:16 not ok 528 sequential/test-http2-settings-flood
13:27:16   ---
13:27:16   duration_ms: 1.37
13:27:16   severity: crashed
13:27:16   exitcode: -1073741819
13:27:16   stack: |-
  • Version: master
  • Platform: Windows
  • Subsystem: http2
@mcollina mcollina added the http2 Issues or PRs related to the http2 subsystem. label Dec 14, 2018
@mcollina
Copy link
Member Author

cc @jasnell

@mcollina
Copy link
Member Author

Prior art: #18251 #19349.

@mcollina
Copy link
Member Author

cc @Trott

@Trott
Copy link
Member

Trott commented Dec 14, 2018

Link to the CI run would be very useful. In particular, I think this was a CI run on the v8.x branch, was it not? It might be a bug that's already been fixed in master.

@Trott
Copy link
Member

Trott commented Dec 14, 2018

Oh, wait, you wrote "master" above. Yeah, link would be good. Would want to know what Windows variant etc.

@Trott
Copy link
Member

Trott commented Dec 14, 2018

Argh! http2. Yeah, that has to be master, not v8.x. I read it as https for some reason. Sorry for all the noise...

@Trott
Copy link
Member

Trott commented Dec 14, 2018

Found one...

https://ci.nodejs.org/job/node-test-binary-windows/22459/COMPILED_BY=vcbt2015,RUNNER=win10,RUN_SUBSET=1/console

test-azure_msft-win10-x64-4

09:53:40 not ok 529 sequential/test-http2-settings-flood
09:53:40   ---
09:53:40   duration_ms: 1.139
09:53:40   severity: crashed
09:53:40   exitcode: -1073741819
09:53:40   stack: |-
09:53:40   ...

Timestamps are different than the console cut-and-paset from @mcollina so this has happened at least twice. Probably a good idea to mark it flaky until it gets worked out. One bugfix is probably going to resolve a ton of these flaky tests all at once.

@Trott
Copy link
Member

Trott commented Dec 14, 2018

Argh! It IS v8.x after all! Yeah, this is probably not affecting master.

(Why did I think http2 didn't exist in v8.x?)

@Trott Trott added the v8.x label Dec 14, 2018
@Trott Trott changed the title flaky sequential/test-http2-settings-flood [v8.x] flaky sequential/test-http2-settings-flood Dec 14, 2018
MylesBorins pushed a commit that referenced this issue Dec 22, 2018
Refs: #25043
PR-URL: #25048
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins
Copy link
Contributor

marked flaky on 8.x in 2bedbdb

@MylesBorins MylesBorins reopened this Dec 22, 2018
MylesBorins pushed a commit that referenced this issue Dec 22, 2018
Refs: #25043
PR-URL: #25048
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@ChALkeR ChALkeR added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Nov 6, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Jan 2, 2020

Node.js v8.x has reached the end-of-life and won't receive any fixes anymore. I am closing this since this issue only applies to Node.js v8.x.

@BridgeAR BridgeAR closed this as completed Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Development

No branches or pull requests

5 participants