-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs.mkdir recursive edge case potential issues #25110
Comments
Fishrock123
added
the
fs
Issues and PRs related to the fs subsystem / file system.
label
Dec 19, 2018
@coreyfarrell thanks for finding this, feel free to ping me in slack and we can see if we can't fix this. |
2 tasks
refack
pushed a commit
to refack/node
that referenced
this issue
Jan 14, 2019
Fixes: nodejs#25110 PR-URL: nodejs#25340 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this issue
Jan 16, 2019
Fixes: nodejs#25110 PR-URL: nodejs#25340 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Example Code:
The same occurs with
fs.mkdir
, I usedfs.mkdirSync
in the example as the code is simpler.I've uncovered these edge cases via sindresorhus/make-dir#7 where I'm working on making that module use the native recursive mkdir when possible. The plan is for
make-dir@2
to emulate the native fs.mkdir recursive for older versions of node, so I'm hoping for clarification on these two potential issues.CC @bcoe
The text was updated successfully, but these errors were encountered: