Investigate test-worker-messageport-transfer-terminate

[joyeecheung]

Reason	parallel/test-worker-messageport-transfer-terminate
Type	JS_TEST_FAILURE
Failed PR	2 (#25125, #25088)
Appeared	test-linuxonecc-rhel72-s390x-1, test-rackspace-ubuntu1604-x64-2
First CI	https://ci.nodejs.org/job/node-test-pull-request/19675/
Last CI	https://ci.nodejs.org/job/node-test-pull-request/19679/

Example

not ok 2085 parallel/test-worker-messageport-transfer-terminate
  ---
  duration_ms: 0.829
  severity: crashed
  exitcode: -6
  stack: |-
    FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal.
     1: 0x15c1bd4 node::Abort() [out/Release/node]
     2: 0x15c27e6 node::OnFatalError(char const*, char const*) [out/Release/node]
     3: 0x17cdc58 v8::Utils::ReportApiFailure(char const*, char const*) [out/Release/node]
     4: 0x1691e82  [out/Release/node]
     5: 0x159d500 node::binding::GetInternalBinding(v8::FunctionCallbackInfo<v8::Value> const&) [out/Release/node]
     6: 0x1876648  [out/Release/node]
     7: 0x18771c6 v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [out/Release/node]
     8: 0x278f75c  [out/Release/node]
  ...

[joyeecheung]

I walked through the recent 100 CI runs and this failure seems to only happen in test-worker-messageport-transfer-terminate, so I suspect the internalBinding causing this should be either worker or messaging.

cc @nodejs/workers @addaleax

[joyeecheung]

The first failure in CI is rebasing onto #25076 (which added this test)

[addaleax]

I can reproduce this locally.

The binding in question should be uv, based on the disassembly of my failed build, so I would be reasonably certain this is being addressed by #25079 – I’ll land it, add a Fixes: tag and we can re-open if necessary.