Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,windows: build and test add-ons on CI #2537

Closed
bnoordhuis opened this issue Aug 25, 2015 · 1 comment
Closed

build,windows: build and test add-ons on CI #2537

bnoordhuis opened this issue Aug 25, 2015 · 1 comment
Labels
build Issues and PRs related to build files or the CI. good first issue Issues that are suitable for first-time contributors. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Comments

@bnoordhuis
Copy link
Member

Continuation of #2428. Building and testing add-ons has been implemented on Unices but not on Windows.

This probably needs to be added to vcbuild.bat although I'm unsure what the best way to do that is. Call out to a python script that builds the add-ons? Normal add-ons in test/addons can be built from a master binding.gyp but that won't work for add-ons scraped from the documentation.

/cc @orangemocha @nodejs/build @nodejs/platform-windows
@bnoordhuis bnoordhuis added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. good first issue Issues that are suitable for first-time contributors. labels Aug 25, 2015
@mathiask88 mathiask88 mentioned this issue Oct 20, 2015
Closed
@Trott
Copy link
Member

Trott commented Feb 11, 2016

/cc @nodejs/testing

@blobor blobor mentioned this issue Mar 24, 2016
Closed
2 tasks
evanlucas pushed a commit that referenced this issue Mar 30, 2016
@evanlucas
win,build: build and test add-ons on test-ci
5b5cb7e 
Added build-addons task, it allows to build and test native addons
during test-ci task. Basically it should work in same way like
Makefile "build-addons" task.

Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: João Reis <reis@janeasystems.com>
PR-URL: #5886
Fixes: #2537
evanlucas pushed a commit that referenced this issue Mar 31, 2016
@evanlucas
win,build: build and test add-ons on test-ci
77bed26 
Added build-addons task, it allows to build and test native addons
during test-ci task. Basically it should work in same way like
Makefile "build-addons" task.

Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: João Reis <reis@janeasystems.com>
PR-URL: #5886
Fixes: #2537
MylesBorins pushed a commit that referenced this issue Apr 11, 2016
win,build: build and test add-ons on test-ci
f7eb483 
Added build-addons task, it allows to build and test native addons
during test-ci task. Basically it should work in same way like
Makefile "build-addons" task.

Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: João Reis <reis@janeasystems.com>
PR-URL: #5886
Fixes: #2537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. good first issue Issues that are suitable for first-time contributors. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bnoordhuis @Trott