Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: ERR_SYNTHETIC issues on v11.x #25750

Closed
cjihrig opened this issue Jan 28, 2019 · 1 comment
Closed

doc: ERR_SYNTHETIC issues on v11.x #25750

cjihrig opened this issue Jan 28, 2019 · 1 comment
Labels
doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. good first issue Issues that are suitable for first-time contributors. help wanted Issues that need assistance from volunteers or PRs that need help to proceed.

Comments

@cjihrig
Copy link
Contributor

cjihrig commented Jan 28, 2019

On v11.x, the ERR_SYNTHETIC header is the wrong size, also causing the list at the top of the errors doc page to be indented incorrectly. This does not impact master.
@cjihrig cjihrig added help wanted Issues that need assistance from volunteers or PRs that need help to proceed. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Jan 28, 2019
@sreepurnajasti
Copy link
Contributor

@cjihrig I would like to take this up.

sreepurnajasti added a commit to sreepurnajasti/node that referenced this issue Jan 28, 2019
@sreepurnajasti
doc: fix err_synthetic issue on v11.x
2f5840e 
Fixes: nodejs#25750
@sreepurnajasti sreepurnajasti mentioned this issue Jan 28, 2019
Closed
2 tasks
addaleax pushed a commit that referenced this issue Feb 6, 2019
@sreepurnajasti @addaleax
doc: fix err_synthetic issue on v11.x
353de0f 
Fixes: #25750

PR-URL: #25770
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. good first issue Issues that are suitable for first-time contributors. help wanted Issues that need assistance from volunteers or PRs that need help to proceed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjihrig @sreepurnajasti