-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readable stops reading #26097
Labels
stream
Issues and PRs related to the stream subsystem.
Comments
@nodejs/streams |
mcollina
added a commit
to mcollina/node
that referenced
this issue
Feb 15, 2019
3 tasks
Fixed in cd302d7. |
pull bot
pushed a commit
to zys-contrib/node
that referenced
this issue
Feb 28, 2019
Fixes: nodejs#26097 PR-URL: nodejs#26135 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Consider the following example, born from discussion in #25969.
Note that
readable.read()
is not called in a loop on purpose.Expected behavior
An endless loop. This works as expected in Node.js < 10.0.0.
Actual behavior
Reading stops after a few reads.
Bisecting points to this commit: 0778f79.
The text was updated successfully, but these errors were encountered: