-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark parameter group #26425
Closed
Labels
benchmark
Issues and PRs related to the benchmark subsystem.
help wanted
Issues that need assistance from volunteers or PRs that need help to proceed.
Comments
BridgeAR
added
help wanted
Issues that need assistance from volunteers or PRs that need help to proceed.
benchmark
Issues and PRs related to the benchmark subsystem.
labels
Mar 4, 2019
I also agree with @BridgeAR as this could reduce the number of computations. I am willing to work on this. |
This was referenced Mar 10, 2019
Closed
Mesteery
added a commit
to Mesteery/node
that referenced
this issue
Jul 6, 2021
Mesteery
added a commit
to Mesteery/node
that referenced
this issue
Jul 6, 2021
Add the `byGroup` option to have parameter grouping. The environment variable `NODE_RUN_BENCHMARK_GROUPS` allows to benchmark only certain groups: `NODE_RUN_BENCHMARK_GROUPS=groupA,groupB`. Fixes: nodejs#26425
Mesteery
added a commit
to Mesteery/node
that referenced
this issue
Jul 6, 2021
Add the `byGroup` option to have benchmark parameter grouping. The environment variable `NODE_RUN_BENCHMARK_GROUPS` allows to benchmark only certain groups: `NODE_RUN_BENCHMARK_GROUPS=groupA,groupB`. Fixes: nodejs#26425
Mesteery
added a commit
to Mesteery/node
that referenced
this issue
Jul 6, 2021
Add the `byGroup` option to have benchmark parameter grouping. The environment variable `NODE_RUN_BENCHMARK_GROUPS` allows to benchmark only certain groups: `NODE_RUN_BENCHMARK_GROUPS=groupA,groupB`. Fixes: nodejs#26425
puskin94
added a commit
to puskin94/node
that referenced
this issue
Aug 15, 2024
Fixes: nodejs#26425 Co-Authored-By: Yaman Kassir <mestery@protonmail.com>
louwers
pushed a commit
to louwers/node
that referenced
this issue
Nov 2, 2024
Fixes: nodejs#26425 Co-Authored-By: Yaman Kassir <mestery@protonmail.com> PR-URL: nodejs#54393 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this issue
Nov 21, 2024
Fixes: nodejs#26425 Co-Authored-By: Yaman Kassir <mestery@protonmail.com> PR-URL: nodejs#54393 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
benchmark
Issues and PRs related to the benchmark subsystem.
help wanted
Issues that need assistance from volunteers or PRs that need help to proceed.
We currently have the possibility to add different parameters when running benchmarks. These result in a matrix how they are run, e.g.,:
This results in 12 variations of the specific benchmark being run (3x
source
* 2xlen
* 2xn
). However, often we only require to test a specific subset of these parameters but it is not possible to define such groups.Example:
Here we'd only run the benchmark
1 * 2 * 1 + 2 * 1 * 2
times (6x).So if anyone would feel like implementing any such grouping functionality, that would be great! It will not be beneficial in all cases but at least in a couple. That way it's possible to reduce overall runtime.
// cc @mscdex
The text was updated successfully, but these errors were encountered: