-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate flaky test eval_messages #2672
Comments
In the six and a half weeks since the build that this test failed on armv7-wheezy, it has not failed again on armv7-wheezy. And it had apparently not failed before that either. Any objections to removing its flaky status? It seems to me that either one of two things are happening:
EDIT: There's also the possibility that it was a problem with the build (e.g., a configuration or OS bug) that has since been corrected. But whatever the case, it seems that there's perhaps not much point in having it marked flaky. If the test fails again, it seems that it is more likely the result of an actual bug in the commit and I'd rather have it flagged than marked as "oh yeah, that test failed, but it fails a lot so you can ignore it". |
This test has not failed on armv7-wheezy in over 6 weeks. Let's remove its "flaky" status. Fixes: nodejs#2672
As seen in #2620 (comment)
https://ci.nodejs.org/job/node-test-commit-arm/434/nodes=armv7-wheezy/tapTestReport/
The text was updated successfully, but these errors were encountered: