-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yet another segmentation fault in node-v4.0.0-rc.1 #2721
Comments
Confirmed, I'm almost certain this is the one seen in #2552
|
@silverwind could you get the JavaScript stack out of that too? You can use https://github.com/thlorenz/lldb-jbt for that. |
@Fishrock123 hmm, can't get that to work:
Anyways, for all I know, #2722 fixes the issue. |
@silverwind you installed it globally, right? Maybe try watching the screencast? |
Yeah, of course. I'm doing it like in the screencast. Maybe try for yourself, you should see the segfault with current master or the 4.0 RCs. |
Should be fixed deps/v8/src/api.cc Workaround solution will be the next commit
Ah this is actually a bug in child_process. PR incoming |
When passing `process.stdin` in `stdio` options to `child_process.spawn`, make sure that its `fd` is getting passed properly to the C++ internals. It is `0`, so the `stdio.fd || stdio` check will return `process.stdin`, instead of the number. Fix: nodejs#2721
Previously, in _validateStdio we were using stdio.fd || stdio. If stdio.fd was falsy (or 0 in the case of stdin), then the entire stdio object would be passed which could cause a crash. Fixes: nodejs#2721 PR-URL: nodejs#2727 Reviewed-By: silverwind - Roman Reiss <me@silverwind.io> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Previously, in _validateStdio we were using stdio.fd || stdio. If stdio.fd was falsy (or 0 in the case of stdin), then the entire stdio object would be passed which could cause a crash. Fixes: #2721 PR-URL: #2727 Reviewed-By: silverwind - Roman Reiss <me@silverwind.io> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Previously, in _validateStdio we were using stdio.fd || stdio. If stdio.fd was falsy (or 0 in the case of stdin), then the entire stdio object would be passed which could cause a crash. Fixes: #2721 PR-URL: #2727 Reviewed-By: silverwind - Roman Reiss <me@silverwind.io> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Fixed in evanlucas@3bc7e58 |
Previously, in _validateStdio we were using stdio.fd || stdio. If stdio.fd was falsy (or 0 in the case of stdin), then the entire stdio object would be passed which could cause a crash. Fixes: #2721 PR-URL: #2727 Reviewed-By: silverwind - Roman Reiss <me@silverwind.io> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
The text was updated successfully, but these errors were encountered: