Syntax Highlighting license

[BethGriggs]

This might not be an issue, but one of our scanning tools picked up on it so thought I'd post it for discussion anyway.

Syntax Highlighting JS (https://github.com/nodejs/node/blob/master/doc/api_assets/sh_main.js) has a GPLv3 license. It is only used in the docs, but I don't know if this could have implications if anyone was to redistribute the docs (perhaps unlikely?).

Should the license potentially be listed/mentioned somewhere else in addition to the file itself?

I notice that SHJS is also over in nodejs/nodejs.org. Do we still need it in nodejs/node, could it be pulled in from nodejs.org? (refs: nodejs/nodejs.org#2150 (comment)).

Admittedly I do not know the history of this file/docs. /cc @nodejs/documentation

[richardlau]

#22831 replaces the file but that PR appears to have stalled.

[BridgeAR]

This is currently discussed in a more generic fashion in #30241.

[BethGriggs]

SHJS was removed from this repository in #33442 (@DerekNonGeneric 🎉), but I am not sure if it can/should be removed from nodejs/nodejs.org too?

[DerekNonGeneric]

but I am not sure if it can/should be removed from nodejs/nodejs.org too?

@BethGriggs, the website appears to be using Prism. Please see the comment below.

LGTM, I'd just point out the org site is running https://prismjs.com/ rather than highlight.js, but I think that shouldn't be an issue.
— #33442 (review)

Were you thinking to use highlight.js everywhere?

[richardlau]

SHJS was removed from this repository in #33442 (@DerekNonGeneric 🎉), but I am not sure if it can/should be removed from nodejs/nodejs.org too?

The old docs, e.g. https://nodejs.org/docs/latest-v0.10.x/api/, reference https://nodejs.org/sh_main.js and https://nodejs.org/sh_javascript.min.js (also see the README in https://github.com/nodejs/nodejs.org/tree/master/static/legacy).

[jasnell]

What action is needed here then?

[targos]

Ping @BethGriggs

[BethGriggs]

As SHJS is still used for the legacy documentation I do not see what we can do about this. Perhaps we can just close as we've now moved away from it in Node.js core.

[DerekNonGeneric]

Yes, we would not want to have old versions' docs un-syntax-highlighted. That would be barbaric.