add missing semicolon #2150
Merged
add missing semicolon #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh_main.js uses semicolons everywhere except in one line. Add the missing semicolon.
vsemozhetbyt
approved these changes
Mar 12, 2019
|
I don't know the history of this dependency, but should it also be changed over in nodejs/node? Do we maintain it in two places? Also, does it need to be called out anywhere that it is licenced as |
fhemberger
approved these changes
Mar 12, 2019
|
I don't think it's needed in nodejs/node any longer. It's part of the legacy docs around version 0.x. |
ghost
merged commit 
|
Thank you all! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sh_main.js uses semicolons everywhere except in one line. Add the
missing semicolon.