Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport ICU-20575 to fix err/crasher in ICU 64.x #27418

Closed
srl295 opened this issue Apr 25, 2019 · 3 comments
Closed

backport ICU-20575 to fix err/crasher in ICU 64.x #27418

srl295 opened this issue Apr 25, 2019 · 3 comments
Assignees
@srl295
Labels
i18n-api Issues and PRs related to the i18n implementation.

Comments

@srl295
Copy link
Member

srl295 commented Apr 25, 2019

  • Subsystem: deps

Tracking: unicode-org/icu#634
Now that #27361 (ICU 64.2) landed, it would be good to pull this in.

This probably exacerbated #27379 on some platforms.
@srl295 srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Apr 25, 2019
@srl295
Copy link
Member Author

srl295 commented Apr 25, 2019

fyi @targos @refack

@srl295 srl295 self-assigned this Apr 25, 2019
@srl295
Copy link
Member Author

srl295 commented Apr 25, 2019 •
edited
Loading

Test case:

env LANG=fr@EURO ./out/Debug/node -p 'new Intl.NumberFormat().resolvedOptions().locale

Crashes with:

Fatal error in ../../deps/v8/src/objects/intl-objects.cc, line 417

Locale::forLocaleTag("fr-x-lvariant-euro-euro") returns U_ILLEGAL_ARGUMENT_ERROR (why? Perhaps an illegal doubled tag.)

After the fix the printout is fr-x-lvariant-euro

(for unknown reasons, v8 patched around some of the other behaviors, so the output will look different than the upstream issue.)

@srl295 srl295 mentioned this issue Apr 26, 2019
Closed
3 tasks
srl295 added a commit to srl295/node that referenced this issue Apr 26, 2019
@srl295
deps: backport ICU-20575 to fix err/crasher
2566e66 
- Floating patch for ICU 64.x
- includes test case

ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20575
Backport of: unicode-org/icu#634
Fixes: nodejs#27418
@targos
Copy link
Member

targos commented Apr 27, 2019

Fixed in #27435

@targos targos closed this as completed Apr 27, 2019
targos pushed a commit that referenced this issue Apr 27, 2019
@srl295 @targos
deps: backport ICU-20575 to fix err/crasher
31ac8b9 
- Floating patch for ICU 64.x
- includes test case

ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20575
Backport of: unicode-org/icu#634
Fixes: #27418

PR-URL: #27435
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this issue Apr 27, 2019
@srl295 @targos
deps: backport ICU-20575 to fix err/crasher
3282ccb 
- Floating patch for ICU 64.x
- includes test case

ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20575
Backport of: unicode-org/icu#634
Fixes: #27418

PR-URL: #27435
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
hashseed added a commit to v8/node that referenced this issue May 2, 2019
@hashseed
Temporarily remove regression test for ICU (fr@EURO)
4edd7fd 
See nodejs#27418
BethGriggs pushed a commit that referenced this issue May 10, 2019
@srl295 @BethGriggs
deps: backport ICU-20575 to fix err/crasher
cdde908 
- Floating patch for ICU 64.x
- includes test case

ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20575
Backport of: unicode-org/icu#634
Fixes: #27418

PR-URL: #27435
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this issue May 16, 2019
@srl295 @MylesBorins
deps: backport ICU-20575 to fix err/crasher
f91a818 
- Floating patch for ICU 64.x
- includes test case

ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20575
Backport of: unicode-org/icu#634
Fixes: #27418

PR-URL: #27435
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
hashseed added a commit to v8/node that referenced this issue May 17, 2019
@hashseed
Temporarily remove regression test for ICU (fr@EURO)
92431ed 
See nodejs#27418
hashseed added a commit to v8/node that referenced this issue Jun 7, 2019
@hashseed
Temporarily remove regression test for ICU (fr@EURO)
955a92c 
See nodejs#27418
hashseed added a commit to v8/node that referenced this issue Jul 1, 2019
@hashseed
Temporarily remove regression test for ICU (fr@EURO)
f9d8db1 
See nodejs#27418
hashseed added a commit to v8/node that referenced this issue Jul 29, 2019
@hashseed
Temporarily remove regression test for ICU (fr@EURO)
2bf796d 
See nodejs#27418
hashseed added a commit to v8/node that referenced this issue Aug 26, 2019
@hashseed
Temporarily remove regression test for ICU (fr@EURO)
ece757b 
See nodejs#27418
victorgomes pushed a commit to v8/node that referenced this issue Sep 30, 2019
@hashseed @victorgomes
Temporarily remove regression test for ICU (fr@EURO)
eda64cf 
See nodejs#27418
victorgomes pushed a commit to v8/node that referenced this issue Nov 22, 2019
@hashseed @victorgomes
Temporarily remove regression test for ICU (fr@EURO)
cac4c56 
See nodejs#27418
victorgomes pushed a commit to v8/node that referenced this issue Feb 4, 2020
@hashseed @victorgomes
Temporarily remove regression test for ICU (fr@EURO)
1c3a4ac 
See nodejs#27418
victorgomes pushed a commit to v8/node that referenced this issue Feb 25, 2020
@hashseed @victorgomes
Temporarily remove regression test for ICU (fr@EURO)
ea810df 
See nodejs#27418
victorgomes pushed a commit to v8/node that referenced this issue Mar 31, 2020
@hashseed @victorgomes
Temporarily remove regression test for ICU (fr@EURO)
8ad18d5 
See nodejs#27418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: backport ICU-20575 to fix err/crasher srl295/node
2 participants
@srl295 @targos