Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freebsd: remove fbsd 10 SA_RESETHAND workaround #27515

Closed
bnoordhuis opened this issue May 1, 2019 · 1 comment
Closed

freebsd: remove fbsd 10 SA_RESETHAND workaround #27515

bnoordhuis opened this issue May 1, 2019 · 1 comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. freebsd Issues and PRs related to the FreeBSD platform.

Comments

@bnoordhuis
Copy link
Member

Once #27246 lands, remove the SA_RESETHAND workaround in src/node.cc, it's no longer needed.

See discussion in #27246 (comment).
@bnoordhuis bnoordhuis added c++ Issues and PRs that require attention from people who are familiar with C++. freebsd Issues and PRs related to the FreeBSD platform. labels May 1, 2019
@bnoordhuis bnoordhuis mentioned this issue May 1, 2019
Merged
2 tasks
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue May 20, 2019
@bnoordhuis
src: remove freebsd SA_RESETHAND workaround
91384d9 
This workaround should no longer be necessary with supported versions
of FreeSBD.

Originall introduced in commit b64983d ("src: reset signal handler to
SIG_DFL on FreeBSD") from March 2015.

Fixes: nodejs#27515
Refs: nodejs#27246 (comment)
@bnoordhuis bnoordhuis mentioned this issue May 20, 2019
Closed
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue May 23, 2019
@bnoordhuis
src: remove freebsd SA_RESETHAND workaround
51a01c7 
This workaround should no longer be necessary with supported versions
of FreeSBD.

Originally introduced in commit b64983d ("src: reset signal handler
to SIG_DFL on FreeBSD") from March 2015.

Fixes: nodejs#27515
Refs: nodejs#27246 (comment)
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@bnoordhuis
Copy link
Member Author

bnoordhuis commented May 23, 2019 •
edited
Loading

Fixed by 6e79658.

pull bot pushed a commit to shakir-abdo/node that referenced this issue May 23, 2019
@bnoordhuis
src: remove freebsd SA_RESETHAND workaround
6e79658 
This workaround should no longer be necessary with supported versions
of FreeSBD.

Originally introduced in commit b64983d ("src: reset signal handler
to SIG_DFL on FreeBSD") from March 2015.

Fixes: nodejs#27515
PR-URL: nodejs#27780
Refs: nodejs#27246 (comment)
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. freebsd Issues and PRs related to the FreeBSD platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: remove freebsd SA_RESETHAND workaround bnoordhuis/io.js
1 participant
@bnoordhuis