-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node fs.copyfileSync hangs when source and destination are identical #27746
Labels
confirmed-bug
Issues with confirmed bugs.
libuv
Issues and PRs related to the libuv dependency or the uv binding.
Comments
addaleax
added
confirmed-bug
Issues with confirmed bugs.
libuv
Issues and PRs related to the libuv dependency or the uv binding.
labels
May 17, 2019
I think if the proposal in libuv/libuv#2237 is implemented, this should be fixed. |
Thanks for quick response! Indeed, it seems likely that this would fix the issue. |
santigimeno
added a commit
to libuv/libuv
that referenced
this issue
Jun 23, 2019
Specifically return success. It fixes a tight loop on unices as `sendfile()` was returning 0 and also makes the function behave the same both on `unix` and `windows`. It partially implements: #2237 PR-URL: #2298 Refs: nodejs/node#27746 Reviewed-By: Jameson Nash <vtjnash@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
cjihrig
added a commit
to cjihrig/node
that referenced
this issue
Jun 29, 2019
Notable changes: - Support for the Haiku platform has been added. - The maximum UV_THREADPOOL_SIZE has been increased from 128 to 1024. - uv_fs_copyfile() now works properly when the source and destination files are the same. PR-URL: nodejs#28449 Fixes: nodejs#27746 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos
pushed a commit
that referenced
this issue
Jul 2, 2019
Notable changes: - Support for the Haiku platform has been added. - The maximum UV_THREADPOOL_SIZE has been increased from 128 to 1024. - uv_fs_copyfile() now works properly when the source and destination files are the same. PR-URL: #28449 Fixes: #27746 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos
pushed a commit
that referenced
this issue
Jul 2, 2019
Notable changes: - Support for the Haiku platform has been added. - The maximum UV_THREADPOOL_SIZE has been increased from 128 to 1024. - uv_fs_copyfile() now works properly when the source and destination files are the same. PR-URL: #28449 Fixes: #27746 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BethGriggs
pushed a commit
to BethGriggs/node
that referenced
this issue
Feb 26, 2020
Notable changes: - Support for the Haiku platform has been added. - The maximum UV_THREADPOOL_SIZE has been increased from 128 to 1024. - uv_fs_copyfile() now works properly when the source and destination files are the same. PR-URL: nodejs#28449 Fixes: nodejs#27746 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BethGriggs
pushed a commit
that referenced
this issue
Mar 2, 2020
Notable changes: - Support for the Haiku platform has been added. - The maximum UV_THREADPOOL_SIZE has been increased from 128 to 1024. - uv_fs_copyfile() now works properly when the source and destination files are the same. PR-URL: #28449 Backport-PR-URL: #31969 Fixes: #27746 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
confirmed-bug
Issues with confirmed bugs.
libuv
Issues and PRs related to the libuv dependency or the uv binding.
Unless the
fs.constants.COPYFILE_EXCL
flag is passed, whensource
anddestination
are the same, Node hangs forever.The text was updated successfully, but these errors were encountered: