Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: histogram: unexport symbols #27778

Closed
bnoordhuis opened this issue May 20, 2019 · 1 comment · Fixed by #27779
Closed

build: histogram: unexport symbols #27778

bnoordhuis opened this issue May 20, 2019 · 1 comment · Fixed by #27779
Labels
build Issues and PRs related to build files or the CI.

Comments

@bnoordhuis
Copy link
Member

Split off from #27664 for separate tracking, see #27664 (comment) and nodejs/node-gyp#1755.
@bnoordhuis bnoordhuis added the build Issues and PRs related to build files or the CI. label May 20, 2019
@bnoordhuis bnoordhuis mentioned this issue May 20, 2019
Merged
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue May 23, 2019
@bnoordhuis
deps: histogram: unexport symbols
ca8e33a 
Fixes: nodejs/node-gyp#1755
Fixes: nodejs#27778
PR-URL: nodejs#27779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@bnoordhuis
Copy link
Member Author

Fixed by ca8e33a.

targos pushed a commit that referenced this issue May 23, 2019
@bnoordhuis @targos
deps: histogram: unexport symbols
3b6424f 
Fixes: nodejs/node-gyp#1755
Fixes: #27778
PR-URL: #27779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: histogram: unexport symbols bnoordhuis/io.js
1 participant
@bnoordhuis