We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I've enabled LTO for openSUSE Tumblweed and this reliably results in a test failure. This is Node 12.3.1.
[ 5754s] not ok 2569 abort/test-addon-uv-handle-leak [ 5754s] --- [ 5754s] duration_ms: 2.202 [ 5754s] severity: fail [ 5754s] exitcode: 1 [ 5754s] stack: |- [ 5754s] assert.js:362 [ 5754s] throw err; [ 5754s] ^ [ 5754s] [ 5754s] AssertionError [ERR_ASSERTION]: uv loop at [0x7fb5bee6eb28] has 0 active handles [ 5754s] [0x559505cc2e70] timer [ 5754s] Close callback: 0x7fb5bee71290 CloseCallback(uv_handle_s*) [/home/abuild/rpmbuild/BUILD/node-v12.3.1/test/addons/uv-handle-leak/build/Release/binding.node] [ 5754s] Data: 0x7fb5bee740e8 example_instance [/home/abuild/rpmbuild/BUILD/node-v12.3.1/test/addons/uv-handle-leak/build/Release/binding.node] [ 5754s] (First field): 0x7fb5bee73db8 [/home/abuild/rpmbuild/BUILD/node-v12.3.1/test/addons/uv-handle-leak/build/Release/binding.node] [ 5754s] [0x559505cf5cc0] timer [ 5754s] Close callback: 0x7fb5bee71290 CloseCallback(uv_handle_s*) [/home/abuild/rpmbuild/BUILD/node-v12.3.1/test/addons/uv-handle-leak/build/Release/binding.node] [ 5754s] Data: (nil) [ 5754s] [0x559505cf5d70] timer [ 5754s] Close callback: 0x7fb5bee71290 CloseCallback(uv_handle_s*) [/home/abuild/rpmbuild/BUILD/node-v12.3.1/test/addons/uv-handle-leak/build/Release/binding.node] [ 5754s] Data: 0x42 [ 5754s] /home/abuild/rpmbuild/BUILD/node-v12.3.1/out/Release/node12[23053]: ../src/debug_utils.cc:286:void node::CheckedUvLoopClose(uv_loop_t*): Assertion `0 && "uv_loop_close() while having open handles"' failed. [ 5754s] 1: 0x559505005360 node::Abort() [/home/abuild/rpmbuild/BUILD/node-v12.3.1/out/Release/node12] [ 5754s] 2: 0x55950500551d [/home/abuild/rpmbuild/BUILD/node-v12.3.1/out/Release/node12] [ 5754s] 3: 0x559505070ca8 [/home/abuild/rpmbuild/BUILD/node-v12.3.1/out/Release/node12] [ 5754s] 4: 0x559504f907d6 [/home/abuild/rpmbuild/BUILD/node-v12.3.1/out/Release/node12] [ 5754s] 5: 0x559504f99391 node::worker::Worker::Run() [/home/abuild/rpmbuild/BUILD/node-v12.3.1/out/Release/node12] [ 5754s] 6: 0x559504f99d9c [/home/abuild/rpmbuild/BUILD/node-v12.3.1/out/Release/node12] [ 5754s] 7: 0x7fb5c30d8faa [/lib64/libpthread.so.0] [ 5754s] 8: 0x7fb5c3dfd71f clone [/lib64/libc.so.6] [ 5754s] [ 5754s] at Object.<anonymous> (/home/abuild/rpmbuild/BUILD/node-v12.3.1/test/abort/test-addon-uv-handle-leak.js:82:5) [ 5754s] at Module._compile (internal/modules/cjs/loader.js:774:30) [ 5754s] at Object.Module._extensions..js (internal/modules/cjs/loader.js:785:10) [ 5754s] at Module.load (internal/modules/cjs/loader.js:641:32) [ 5754s] at Function.Module._load (internal/modules/cjs/loader.js:556:12) [ 5754s] at Function.Module.runMain (internal/modules/cjs/loader.js:837:10) [ 5754s] at internal/main/run_main_module.js:17:11 { [ 5754s] generatedMessage: false, [ 5754s] code: 'ERR_ASSERTION', [ 5754s] actual: false, [ 5754s] expected: true, [ 5754s] operator: '==' [ 5754s] } [ 5754s] ...
The complete build log is at https://build.opensuse.org/public/build/devel:languages:nodejs/openSUSE_Tumbleweed/x86_64/nodejs12/_log
This test failure is showing up on all architectures, including things like S390 on SLES12 SP3. https://build.opensuse.org/package/show/devel:languages:nodejs/nodejs12
This seems to be related to the error reported in #7400
The text was updated successfully, but these errors were encountered:
test: missing vtable in test when LTO is enabled
e466058
Issue: nodejs#28026
test: make sure vtable is generated in addon test with LTO
0525ed8
Fixes: nodejs#28026
b31bfad
87e977a
PR-URL: #28057 Fixes: #28026 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Successfully merging a pull request may close this issue.
I've enabled LTO for openSUSE Tumblweed and this reliably results in a test failure. This is Node 12.3.1.
The complete build log is at https://build.opensuse.org/public/build/devel:languages:nodejs/openSUSE_Tumbleweed/x86_64/nodejs12/_log
This test failure is showing up on all architectures, including things like S390 on SLES12 SP3.
https://build.opensuse.org/package/show/devel:languages:nodejs/nodejs12
This seems to be related to the error reported in #7400
The text was updated successfully, but these errors were encountered: