Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined variable icu_path during configure when system-icu is set #28052

Closed
AdamMajer opened this issue Jun 4, 2019 · 1 comment
Closed

Undefined variable icu_path during configure when system-icu is set #28052

AdamMajer opened this issue Jun 4, 2019 · 1 comment
Labels
build Issues and PRs related to build files or the CI. confirmed-bug Issues with confirmed bugs. i18n-api Issues and PRs related to the i18n implementation.

Comments

@AdamMajer
Copy link
Contributor

Version: node-git master branch
Platform: openSUSE Tumbleweed

node-git.f585dca83d> ./configure --prefix=/usr --enable-lto --shared-zlib --shared-cares 
--with-intl=system-icu --shared-nghttp2 --gdb --without-dtrace --openssl-use-def-ca-store

gyp: Undefined variable icu_path in
/home/abuild/rpmbuild/BUILD/node-git.f585dca83d/tools/v8_gypfiles/v8.gyp 
while loading dependencies of /home/abuild/rpmbuild/BUILD/node-git.f585dca83d/node.gyp
while trying to load /home/abuild/rpmbuild/BUILD/node-git.f585dca83d/node.gyp
Error running GYP

There are no problems with Node 12.x branches.
@bnoordhuis bnoordhuis added build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation. labels Jun 6, 2019
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Jun 7, 2019
@bnoordhuis
build: unbreak --with-intl=system-icu build
167f4b0 
Include directories are configured by the tools/icu/icu-*.gyp files.
The v8.gyp file doesn't need to add them and in fact the way it did
that breaks when building against an external copy of ICU.

Fixes: nodejs#28052
@bnoordhuis bnoordhuis mentioned this issue Jun 7, 2019
Closed
@bnoordhuis bnoordhuis added the confirmed-bug Issues with confirmed bugs. label Jun 7, 2019
@AdamMajer
Copy link
Contributor Author

This now affects the Node 12.x staging branch.

@Trott Trott closed this as completed in 3cdd5a2 Jun 14, 2019
BridgeAR pushed a commit that referenced this issue Jun 17, 2019
@bnoordhuis @BridgeAR
build: unbreak --with-intl=system-icu build
7d0ffee 
Include directories are configured by the tools/icu/icu-*.gyp files.
The v8.gyp file doesn't need to add them and in fact the way it did
that breaks when building against an external copy of ICU.

Fixes: #28052
PR-URL: #28118
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Jun 18, 2019
@bnoordhuis @targos
build: unbreak --with-intl=system-icu build
6a2d8e2 
Include directories are configured by the tools/icu/icu-*.gyp files.
The v8.gyp file doesn't need to add them and in fact the way it did
that breaks when building against an external copy of ICU.

Fixes: #28052
PR-URL: #28118
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. confirmed-bug Issues with confirmed bugs. i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: unbreak --with-intl=system-icu build bnoordhuis/io.js
2 participants
@bnoordhuis @AdamMajer