Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: ClientRequest might never emit close if has agent and is aborted #28684

Closed
ronag opened this issue Jul 14, 2019 · 2 comments
Closed

http: ClientRequest might never emit close if has agent and is aborted #28684

ronag opened this issue Jul 14, 2019 · 2 comments
Labels
http Issues or PRs related to the http subsystem.

Comments

@ronag
Copy link
Member

ronag commented Jul 14, 2019

Not sure how to trigger this since I'm not a heavy agent user but looking at the following section:

https://github.com/nodejs/node/blob/master/lib/_http_client.js#L710

If I call abort it looks like only abort might be emitted and close is never.
@ronag
Copy link
Member Author

ronag commented Jul 14, 2019

@mcollina ping

@ronag ronag mentioned this issue Jul 14, 2019
Closed
4 tasks
@lpinca lpinca added the http Issues or PRs related to the http subsystem. label Jul 28, 2019
Trott pushed a commit that referenced this issue Oct 15, 2019
@ronag @Trott
http: emit close on socket re-use
d247a8e 
PR-URL: #28685
Refs: #28684
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@ronag
Copy link
Member Author

ronag commented Apr 19, 2020

I believe this has been resolved.

@ronag ronag closed this as completed Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lpinca @ronag