Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky test-stdout-close-catch on FreeBSD in CI #28803

Closed
Trott opened this issue Jul 22, 2019 · 6 comments
Closed

Investigate flaky test-stdout-close-catch on FreeBSD in CI #28803

Trott opened this issue Jul 22, 2019 · 6 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. freebsd Issues and PRs related to the FreeBSD platform.

Comments

@Trott
Copy link
Member

Trott commented Jul 22, 2019

https://ci.nodejs.org/job/node-test-commit-freebsd/27488/nodes=freebsd11-x64/console on test-digitalocean-freebsd11-x64-1

00:20:42 not ok 1923 parallel/test-stdout-close-catch
00:20:42   ---
00:20:42   duration_ms: 120.101
00:20:42   severity: fail
00:20:42   exitcode: -15
00:20:42   stack: |-
00:20:42     timeout
00:20:42   ...

It seems to be timing out along with parallel/test-worker-message-port-message-before-close a fair amount. In addition to the one above, there's:

In all three cases, those two tests timed out.

@nodejs/testing @nodejs/platform-freebsd

@Trott Trott added freebsd Issues and PRs related to the FreeBSD platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Jul 22, 2019
@anandsuresh
Copy link
Contributor

Seems like all 3 links in this ticket have expired. I'm unsure of how to gain access to test machines to be able to re-run/re-test this. @Trott any pointers?

@Trott
Copy link
Member Author

Trott commented Sep 26, 2019

Seems like all 3 links in this ticket have expired. I'm unsure of how to gain access to test machines to be able to re-run/re-test this. @Trott any pointers?

You can try to emulate locally of course. The entire relevant part of the log is reproduced above. Here's one that hasn't expired yet as of this writing:

https://ci.nodejs.org/job/node-test-commit-freebsd/nodes=freebsd11-x64/28495/console

And for posterity:

11:50:58 not ok 1969 parallel/test-stdout-close-catch
11:50:58   ---
11:50:58   duration_ms: 120.50
11:50:58   severity: fail
11:50:58   exitcode: -15
11:50:58   stack: |-
11:50:58     timeout
11:50:58   ...

If you want login access to the actual test machines, that can be requested with an issue in the nodejs/build repository, but you'll need one or two people on the Build team to vouch for you.

@saper
Copy link

saper commented Nov 1, 2019

Is this reproducible with a simple

ktrace -idf p1 node test/fixtures/catch-stdout-error.js | ktrace -idf p2 node -e "process.stdin.on('data' , () => process.exit(1))"

Also, do we need to use -p to print process.stdin to the stdout in the second process?

'-pe "process.stdin.on(\'data\' , () => process.exit(1))"';

@sam-github
Copy link
Contributor

Still happening: https://ci.nodejs.org/job/node-test-commit-freebsd/30771/

Should it be marked skip?

@sam-github
Copy link
Contributor

sam-github added a commit to sam-github/node that referenced this issue Apr 17, 2020
addaleax pushed a commit that referenced this issue Apr 28, 2020
Refs: #28803

PR-URL: #32849
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this issue Apr 28, 2020
Test name test-worker-message-port-message-before-close is too long for
a commit message description.

Refs: #31280

PR-URL: #32849
Refs: #28803
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this issue May 4, 2020
Refs: #28803

PR-URL: #32849
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this issue May 4, 2020
Test name test-worker-message-port-message-before-close is too long for
a commit message description.

Refs: #31280

PR-URL: #32849
Refs: #28803
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this issue May 7, 2020
Refs: #28803

PR-URL: #32849
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this issue May 7, 2020
Test name test-worker-message-port-message-before-close is too long for
a commit message description.

Refs: #31280

PR-URL: #32849
Refs: #28803
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this issue May 13, 2020
Refs: #28803

PR-URL: #32849
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this issue May 13, 2020
Test name test-worker-message-port-message-before-close is too long for
a commit message description.

Refs: #31280

PR-URL: #32849
Refs: #28803
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
richardlau pushed a commit that referenced this issue Jul 1, 2020
Refs: #28803

PR-URL: #32849
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos
Copy link
Member

targos commented Nov 20, 2021

Closing as there was no recent activity

@targos targos closed this as completed Nov 20, 2021
Trott added a commit to Trott/io.js that referenced this issue Feb 18, 2022
The corresponding issue was closed 3 months ago and it has apparently
been a long time since the failure has been seen in CI.

Refs: nodejs#28803
nodejs-github-bot pushed a commit that referenced this issue Feb 19, 2022
The corresponding issue was closed 3 months ago and it has apparently
been a long time since the failure has been seen in CI.

Refs: #28803

PR-URL: #42045
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
bengl pushed a commit to bengl/node that referenced this issue Feb 21, 2022
The corresponding issue was closed 3 months ago and it has apparently
been a long time since the failure has been seen in CI.

Refs: nodejs#28803

PR-URL: nodejs#42045
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
bengl pushed a commit to bengl/node that referenced this issue Feb 21, 2022
The corresponding issue was closed 3 months ago and it has apparently
been a long time since the failure has been seen in CI.

Refs: nodejs#28803

PR-URL: nodejs#42045
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
bengl pushed a commit that referenced this issue Feb 21, 2022
The corresponding issue was closed 3 months ago and it has apparently
been a long time since the failure has been seen in CI.

Refs: #28803

PR-URL: #42045
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
bengl pushed a commit that referenced this issue Feb 21, 2022
The corresponding issue was closed 3 months ago and it has apparently
been a long time since the failure has been seen in CI.

Refs: #28803

PR-URL: #42045
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
bengl pushed a commit that referenced this issue Feb 22, 2022
The corresponding issue was closed 3 months ago and it has apparently
been a long time since the failure has been seen in CI.

Refs: #28803

PR-URL: #42045
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this issue Apr 21, 2022
The corresponding issue was closed 3 months ago and it has apparently
been a long time since the failure has been seen in CI.

Refs: nodejs#28803

PR-URL: nodejs#42045
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
The corresponding issue was closed 3 months ago and it has apparently
been a long time since the failure has been seen in CI.

Refs: #28803

PR-URL: #42045
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
The corresponding issue was closed 3 months ago and it has apparently
been a long time since the failure has been seen in CI.

Refs: #28803

PR-URL: #42045
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. freebsd Issues and PRs related to the FreeBSD platform.
Projects
None yet
Development

No branches or pull requests

5 participants