Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot read property 'bigint' of undefined #29113

Closed
UziTech opened this issue Aug 14, 2019 · 4 comments
Closed

Cannot read property 'bigint' of undefined #29113

UziTech opened this issue Aug 14, 2019 · 4 comments
Labels
fs Issues and PRs related to the fs subsystem / file system. good first issue Issues that are suitable for first-time contributors.

Comments

@UziTech
Copy link
Contributor

UziTech commented Aug 14, 2019

  • Version:v10.5 - v12.*
  • Platform: Windows 10 x64
  • Subsystem: fs

if fs.stat is passed undefined as the second parameter it throws the error:

Cannot read property 'bigint' of undefined
UziTech added a commit to UziTech/node that referenced this issue Aug 14, 2019
@UziTech
fs: add default options
41e93e9 
Fixes: nodejs#29113
This was referenced Aug 14, 2019
Closed
Closed
@Trott Trott added the fs Issues and PRs related to the fs subsystem / file system. label Aug 14, 2019
@Trott
Copy link
Member

Trott commented Aug 14, 2019

@nodejs/fs

@joyeecheung
Copy link
Member

From the docs fs.stat(fd, undefined, callback) is not a valid signature - when the second parameter is passed, it must be an object. But a better error message would be nice - or we could support undefined as option by making the second parameter default to {}. Marking as a good-first-issue. (note that this also happens to fs.fstat and fs.lstat)

@joyeecheung joyeecheung added the good first issue Issues that are suitable for first-time contributors. label Aug 14, 2019
@c0deWookiee

This comment has been minimized.

Sign in to view
@UziTech
Copy link
Contributor Author

UziTech commented Aug 15, 2019

@c0deWookiee there is already a PR that fixes this issue #29114

@Trott Trott closed this as completed in 4111c57 Aug 16, 2019
targos pushed a commit that referenced this issue Aug 19, 2019
@UziTech @targos
fs: add default options for *stat()
178caa5 
PR-URL: #29114
Fixes: #29113
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fs: add default options for stat, fstat, and lstat UziTech/node
4 participants
@UziTech @Trott @joyeecheung @c0deWookiee