Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that napi_get_date_value() ignores leap seconds as per spec #29439

Closed
gabrielschulhof opened this issue Sep 4, 2019 · 2 comments
Closed

Document that napi_get_date_value() ignores leap seconds as per spec #29439

gabrielschulhof opened this issue Sep 4, 2019 · 2 comments
Labels
doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.

Comments

@gabrielschulhof
Copy link
Contributor

#29401 (comment):

I'm actually not sure whether it does or does not account for leap seconds.

From https://tc39.es/ecma262/#sec-time-values-and-time-range:

Time in ECMAScript does not observe leap seconds; they are ignored.
@gabrielschulhof gabrielschulhof added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Sep 4, 2019
@levhita
Copy link
Contributor

levhita commented Sep 15, 2019

I'm guessing is the same case with napi_create_date

levhita added a commit to levhita/node that referenced this issue Sep 15, 2019
@levhita
doc: added leap second behavior to napi_create_date and napi_get_date…
dbd977a 
…_value

napi_create_date and napi_get_date_value ignore leap seconds as per
ECMAScript spec that follows POSIX spec for time, comments added to the
documentation where added fo clarify it.

fixes: nodejs#29439
@levhita
Copy link
Contributor

levhita commented Sep 15, 2019

Here, finished PR #29569

@Trott Trott closed this as completed in 90b5cdb Sep 17, 2019
targos pushed a commit that referenced this issue Sep 20, 2019
@levhita @targos
doc: add leap second behavior notes for napi methods
33018ab 
napi_create_date and napi_get_date_value ignore leap seconds as per
ECMAScript spec that follows POSIX spec for time, comments added to the
documentation where added fo clarify it.

PR-URL: #29569
Fixes: #29439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR pushed a commit that referenced this issue Sep 25, 2019
@levhita @BridgeAR
doc: add leap second behavior notes for napi methods
55631f4 
napi_create_date and napi_get_date_value ignore leap seconds as per
ECMAScript spec that follows POSIX spec for time, comments added to the
documentation where added fo clarify it.

PR-URL: #29569
Fixes: #29439
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@levhita @gabrielschulhof