Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAPI version check fail in test/parallel/test-process-versions.js #29509

Closed
devsnek opened this issue Sep 9, 2019 · 3 comments
Closed

NAPI version check fail in test/parallel/test-process-versions.js #29509

devsnek opened this issue Sep 9, 2019 · 3 comments
Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.

Comments

@devsnek
Copy link
Member

devsnek commented Sep 9, 2019 •
edited
Loading

i'm seeing this test fail locally:

node/test/parallel/test-process-versions.js

Lines 49 to 50 in 8217990

assert.strictEqual(process.config.variables.napi_build_version,
process.versions.napi); 

> process.config.variables.napi_build_version
'4'
> process.versions.napi
'5'
>

cc @nodejs/n-api
@devsnek devsnek added test Issues and PRs related to the tests. node-api Issues and PRs related to the Node-API. labels Sep 9, 2019
@addaleax
Copy link
Member

addaleax commented Sep 9, 2019

Does re-running ./configure help?

@devsnek
Copy link
Member Author

devsnek commented Sep 9, 2019 •
edited
Loading

@addaleax that did fix it. is that a bug in our automatic running of ./configure?

@addaleax
Copy link
Member

addaleax commented Sep 9, 2019

@devsnek I think this would require re-running ./config.status when src/node_version.h changes… that migth be doable?

addaleax added a commit to addaleax/node that referenced this issue Sep 9, 2019
@addaleax
build: re-run configure on node_version.h change
2765e5c 
Fixes: nodejs#29509
@addaleax addaleax mentioned this issue Sep 9, 2019
Closed
2 tasks
targos pushed a commit that referenced this issue Sep 20, 2019
@addaleax @targos
build: re-run configure on node_version.h change
0c91bc0 
Fixes: #29509

PR-URL: #29510
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BridgeAR pushed a commit that referenced this issue Sep 25, 2019
@addaleax @BridgeAR
build: re-run configure on node_version.h change
c304594 
Fixes: #29509

PR-URL: #29510
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: re-run configure on node_version.h change addaleax/node
2 participants
@addaleax @devsnek