-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better description of statuscode handling and improve example #29714
Comments
Hi, I can handle that. |
szhigunov
added a commit
to szhigunov/node
that referenced
this issue
Dec 11, 2019
Clearly describe that any 2xx statusCode indicates success response Fixes: nodejs#29714
@DanielRuf What do you think the code should check for instead? A previous contributor's attempt to make the status code check more lenient resulted in this comment:
|
Trott
added
doc
Issues and PRs related to the documentations.
http
Issues or PRs related to the http subsystem.
labels
Dec 17, 2019
jasnell
added a commit
to jasnell/node
that referenced
this issue
Jul 6, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently https://nodejs.org/api/http.html#http_http_get_url_options_callback mentions only
200
but any2xx
statuscode is asuccess
and not an error.This should be improved.
If you have a question, suggestion or issue regarding our website,
please post it in https://github.com/nodejs/nodejs.org!
Issues with the Node.js API documentation should be posted here. All other
issues regarding the website will be closed.
The text was updated successfully, but these errors were encountered: