Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #28045 #29992

Closed
lal12 opened this issue Oct 16, 2019 · 2 comments
Closed

Backport #28045 #29992

lal12 opened this issue Oct 16, 2019 · 2 comments

Comments

@lal12
Copy link
Contributor

lal12 commented Oct 16, 2019 •
edited
Loading

Could my PR (#28045) into master be backported to v10.17.x?
@richardlau
Copy link
Member

cc @nodejs/lts @BethGriggs

This sounds reasonable, and has lived in current for long enough that this should be low risk.

AshCripps pushed a commit to AshCripps/node that referenced this issue Oct 17, 2019
@lal12
deps: dlloads node static linked executable
ed747ba 
OpenSSL dlloads itself to prevent unloading, in case it might be
dynamically loaded. However when linked statically this will lead to
dloading the main executable.

Refs: nodejs#21848 (comment)
Fixes: nodejs#29992
PR-URL: nodejs#28045
Fixes: nodejs#27925
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@AshCripps AshCripps mentioned this issue Oct 17, 2019
Closed
2 tasks
BethGriggs pushed a commit that referenced this issue Oct 17, 2019
@lal12 @BethGriggs
deps: dlloads node static linked executable
333963e 
OpenSSL dlloads itself to prevent unloading, in case it might be
dynamically loaded. However when linked statically this will lead to
dloading the main executable.

Refs: #21848 (comment)
Fixes: #29992

Backport-PR-URL: #30005
PR-URL: #28045
Fixes: #27925
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@richardlau
Copy link
Member

richardlau commented Oct 31, 2019 •
edited
Loading

Backported and went out in 10.17.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richardlau @lal12