Shouldn't DNS error code 'EADNAME' be 'EBADNAME'?

[maarten-t]

See https://github.com/nodejs/node/blob/master/lib/dns.js#L333

exports.ADNAME = 'EADNAME';

This line defines the error code ADNAME as 'EADNAME'. Shouldn't it be BADNAME and 'EBADNAME' respectively?

exports.BADNAME = 'EBADNAME';

[ChALkeR]

The doc mentions BADNAME: https://nodejs.org/api/dns.html#dns_error_codes

[silverwind]

Looks like an mistake in ecfe32e. This change would be a semver-major.

[silverwind]

(Unless that error code isn't returned by the API)

[ChALkeR]

@silverwind Adding exports.BADNAME would be a semver-minor, removing exports.ADNAME would be a semver-major in any case (even if not returned by the API). So I would prefer that to be two separate commits, one of which could be pulled in 4.x.

[silverwind]

What are these exports actually used for exactly? They don't seem to be involved in actual error handling. They certainly are undocumented, so semver rules don't strictly apply.

[silverwind]

cc: @piscisaureus who added them in 858f230

[ChALkeR]

https://nodejs.org/api/dns.html#dns_error_codes

[silverwind]

Oh, right, comparison. Well, I think a replacement here would qualify as a bugfix to match the documentation, so I think it'd be fine in a patch release actually.

[silverwind]

Filed #3051.

[trevnorris]

Agreed that if the documented result doesn't match how the code works then it's a bug fix.

[silverwind]

Landed in two seperate commits. exports.BADNAME will be available next version. exports.ADNAME will be removed in 5.0.0.