Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: set arraybuffer_untransferable_private_symbol for ArrayBuffer whose buffers are not own by BackingStore #31052

Closed
thangktran opened this issue Dec 21, 2019 · 2 comments
Closed

src: set arraybuffer_untransferable_private_symbol for ArrayBuffer whose buffers are not own by BackingStore #31052

thangktran opened this issue Dec 21, 2019 · 2 comments

Comments

@thangktran
Copy link
Contributor

this is a tracking issue for #30915 (comment)
@thangktran thangktran mentioned this issue Dec 21, 2019
Closed
4 tasks
thangktran added a commit to thangktran/node that referenced this issue Dec 23, 2019
@thangktran
src: set arraybuffer_untransferable_private_symbol
0d11d4c 
for `ArrayBuffer` whose buffers are not own by `BackingStore`. This
would help us avoid problem with the new V8 BackingStore API where new
`ArrayBuffer` is allocated at the same place of previous `ArrayBuffer`
that is still being tracked in `BackingStore` table.

Ref: nodejs#31052
BridgeAR pushed a commit that referenced this issue Dec 25, 2019
@thangktran @BridgeAR
src: set arraybuffer_untransferable_private_symbol
90f7a5c 
for `ArrayBuffer` whose buffers are not own by `BackingStore`. This
would help us avoid problem with the new V8 BackingStore API where new
`ArrayBuffer` is allocated at the same place of previous `ArrayBuffer`
that is still being tracked in `BackingStore` table.

PR-URL: #31053
Refs: #31052
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@gireeshpunathil
Copy link
Member

@thangktran - can this be closed since #31053 is landed? or are there more pending work on this?

@thangktran
Copy link
Contributor Author

@thangktran - can this be closed since #31053 is landed? or are there more pending work on this?

Oh right i forget to close this. Thank you for the ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gireeshpunathil @thangktran