Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: bug when the length of preview output is exactly equal to the terminal width #31291

Closed
ZYSzys opened this issue Jan 10, 2020 · 1 comment
Closed

repl: bug when the length of preview output is exactly equal to the terminal width #31291

ZYSzys opened this issue Jan 10, 2020 · 1 comment
Labels
confirmed-bug Issues with confirmed bugs. repl Issues and PRs related to the REPL subsystem.

Comments

@ZYSzys
Copy link
Member

ZYSzys commented Jan 10, 2020

  • Version: master
  • Platform: macOS
  • Subsystem: repl

When the length of preview output is exactly equal to the terminal width, the cursor's position move to the end of current line, which seems to be a bug.

Kapture 2020-01-10 at 17 56 23

/cc @BridgeAR
@ZYSzys ZYSzys added the repl Issues and PRs related to the REPL subsystem. label Jan 10, 2020
@BridgeAR
Copy link
Member

BridgeAR commented Jan 10, 2020 •
edited
Loading

This should already be fixed. Did you pull the latest changes?
Update: seems like I was wrong.

@BridgeAR BridgeAR added the confirmed-bug Issues with confirmed bugs. label Jan 10, 2020
BridgeAR added a commit to BridgeAR/node that referenced this issue Jan 10, 2020
@BridgeAR
repl: fix preview cursor position
8930aa1 
The cusor position was off in case the preview was exactly as long
as the current terminal was wide.

Fixes: nodejs#31291
@BridgeAR BridgeAR mentioned this issue Jan 10, 2020
Closed
4 tasks
MylesBorins pushed a commit that referenced this issue Jan 16, 2020
@BridgeAR @MylesBorins
repl: fix preview cursor position
c252356 
The cusor position was off in case the preview was exactly as long
as the current terminal was wide.

PR-URL: #31293
Fixes: #31291
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit to targos/node that referenced this issue Apr 25, 2020
@BridgeAR @targos
repl: fix preview cursor position
9b64025 
The cusor position was off in case the preview was exactly as long
as the current terminal was wide.

PR-URL: nodejs#31293
Fixes: nodejs#31291
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue Apr 28, 2020
@BridgeAR @targos
repl: fix preview cursor position
3867f20 
The cusor position was off in case the preview was exactly as long
as the current terminal was wide.

PR-URL: #31293
Fixes: #31291
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

repl: fix preview cursor position BridgeAR/node
2 participants
@BridgeAR @ZYSzys