Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build nodejs 13.7.0 fail while invoking "icutrim.py" #31650

Closed
jmercier-lbi opened this issue Feb 5, 2020 · 4 comments
Closed

build nodejs 13.7.0 fail while invoking "icutrim.py" #31650

jmercier-lbi opened this issue Feb 5, 2020 · 4 comments
Labels
i18n-api Issues and PRs related to the i18n implementation. python PRs and issues that require attention from people who are familiar with Python.

Comments

@jmercier-lbi
Copy link
Contributor

  • Version: 13.7.0
  • Platform: linux
  • Subsystem: centos 7
$ ./configure --prefix="${PREFIX}" \
           --shared \
           --shared-zlib \
           --without-dtrace \
           --with-intl=small-icu \
           --debug-nghttp2 \
           --openssl-use-def-ca-store
$ make -j4
...
nodejs-13.7.0: m = pat.match(line)
nodejs-13.7.0: TypeError: cannot use a string pattern on a bytes-like object
nodejs-13.7.0: make[1]: *** [node-13.7.0/out/Release/obj/gen/icutmp/icudt65l.dat] Error 1
nodejs-13.7.0: make[1]: *** Waiting for unfinished jobs....
@jmercier-lbi jmercier-lbi changed the title build nodejs 13.7.0 fail while inoking "icutrim.py" build nodejs 13.7.0 fail while invoking "icutrim.py" Feb 5, 2020
@jmercier-lbi
Copy link
Contributor Author

jmercier-lbi commented Feb 5, 2020

I suggest this patch

diff -up icu/icutrim.py.ori icu/icutrim.py
--- icu/icutrim.py.ori	2020-02-05 18:53:00.896320425 +0100
+++ icu/icutrim.py	2020-02-05 18:53:29.743965979 +0100
@@ -317,7 +317,7 @@ def removeList(count=0):
             erritems = fi.readlines()
             fi.close()
             #Item zone/zh_Hant_TW.res depends on missing item zone/zh_Hant.res
-            pat = re.compile("""^Item ([^ ]+) depends on missing item ([^ ]+).*""")
+            pat = re.compile(rb"^Item ([^ ]+) depends on missing item ([^ ]+).*")
             for i in range(len(erritems)):
                 line = erritems[i].strip()
                 m = pat.match(line)

@sam-github
Copy link
Contributor

to: @nodejs/python

@sam-github
Copy link
Contributor

to: @nodejs/i18n

@sam-github sam-github added i18n-api Issues and PRs related to the i18n implementation. python PRs and issues that require attention from people who are familiar with Python. labels Feb 6, 2020
@richardlau richardlau linked a pull request Feb 6, 2020 that will close this issue
bioinfornatics pushed a commit to bioinfornatics/node that referenced this issue Feb 26, 2020
@srl295
Copy link
Member

srl295 commented Mar 19, 2020

I confirm this is fixed by #31659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-api Issues and PRs related to the i18n implementation. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants