-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node v14.0.0 : Accessing non-existent property '__esModule' of module exports inside circular dependency #33046
Comments
addaleax
added a commit
to addaleax/node
that referenced
this issue
Apr 24, 2020
Since this property access is performed by generated code, and not used for accessing the actual exports of a module (and because transpilers generally define it as the first key of `module.exports` when it *is* present), it should be okay to allow it. Refs: nodejs#29935 Fixes: nodejs#33046
3 tasks
Thanks for the report! #33048 should fix this. |
BethGriggs
pushed a commit
that referenced
this issue
Apr 27, 2020
Since this property access is performed by generated code, and not used for accessing the actual exports of a module (and because transpilers generally define it as the first key of `module.exports` when it *is* present), it should be okay to allow it. Refs: #29935 Fixes: #33046 PR-URL: #33048 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
BethGriggs
pushed a commit
that referenced
this issue
Apr 28, 2020
Since this property access is performed by generated code, and not used for accessing the actual exports of a module (and because transpilers generally define it as the first key of `module.exports` when it *is* present), it should be okay to allow it. Refs: #29935 Fixes: #33046 PR-URL: #33048 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
BethGriggs
pushed a commit
that referenced
this issue
Apr 28, 2020
Since this property access is performed by generated code, and not used for accessing the actual exports of a module (and because transpilers generally define it as the first key of `module.exports` when it *is* present), it should be okay to allow it. Refs: #29935 Fixes: #33046 PR-URL: #33048 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version: v14.0.0
Platform:
Linux 5.3.0-42-generic # 34~18.04.1-Ubuntu SMP Fri Feb 28 13:42:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
What steps will reproduce the bug?
npx sequelize-cli db:migrate
How often does it reproduce? Is there a required condition?
i.
npx sequelize-cli db:migrate
===>And even on TravisCI, it is failing
What is the expected behavior?
What do you see instead?
I am getting the following warnings:
Additional information
npx cross-env NODE_OPTIONS="--trace-warnings" yarn run migrations
and got this instead:The text was updated successfully, but these errors were encountered: