Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugger: node --debug-port=1234 debug t.js doesn't work #3345

Closed
bnoordhuis opened this issue Oct 13, 2015 · 0 comments
Closed

debugger: node --debug-port=1234 debug t.js doesn't work #3345

bnoordhuis opened this issue Oct 13, 2015 · 0 comments

Comments

@bnoordhuis
Copy link
Member 

$ cat t.js
debugger;

$ node --debug-port=1234 debug t.js
< Debugger listening on port 5858  # <- this is wrong
debug> . ok
break in t.js:1

# in another window
$ node --debug-port=4321 debug t.js
< Error: listen EADDRINUSE :::5858
<     at Object.exports._errnoException (util.js:874:11)
<     at exports._exceptionWithHostPort (util.js:897:20)
<     at Agent.Server._listen2 (net.js:1234:14)
<     at listen (net.js:1270:10)
<     at Agent.Server.listen (net.js:1366:5)
<     at Object.start (_debug_agent.js:21:9)
<     at startup (node.js:70:9)
<     at node.js:961:3

# in first window
unhandled res:{"seq":4,"request_seq":1,"type":"response","command":"scripts",...

It makes it impossible to debug more than one process at the same time.
@bnoordhuis bnoordhuis mentioned this issue Oct 21, 2015
Closed
@bnoordhuis bnoordhuis mentioned this issue Oct 21, 2015
Merged
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue May 25, 2016
@bnoordhuis
debugger: propagate --debug-port= to debuggee
18fb4f9 
Before this commit `node --debug-port=1234 debug t.js` ignored the
--debug-port= argument, binding to the default port 5858 instead,
making it impossible to debug more than one process on the same
machine that way.

This commit also reduces the number of places where the default port
is hard-coded by one.

Fixes: nodejs#3345
PR-URL: nodejs#3470
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit to Fishrock123/node that referenced this issue May 30, 2016
@bnoordhuis @Fishrock123
debugger: propagate --debug-port= to debuggee
b035c0d 
Before this commit `node --debug-port=1234 debug t.js` ignored the
--debug-port= argument, binding to the default port 5858 instead,
making it impossible to debug more than one process on the same
machine that way.

This commit also reduces the number of places where the default port
is hard-coded by one.

Fixes: nodejs#3345
PR-URL: nodejs#3470
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this issue Jun 2, 2016
@bnoordhuis @rvagg
debugger: propagate --debug-port= to debuggee
2184e77 
Before this commit `node --debug-port=1234 debug t.js` ignored the
--debug-port= argument, binding to the default port 5858 instead,
making it impossible to debug more than one process on the same
machine that way.

This commit also reduces the number of places where the default port
is hard-coded by one.

Fixes: #3345
PR-URL: #3470
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Jun 29, 2016
@bnoordhuis
debugger: propagate --debug-port= to debuggee
ceb1377 
Before this commit `node --debug-port=1234 debug t.js` ignored the
--debug-port= argument, binding to the default port 5858 instead,
making it impossible to debug more than one process on the same
machine that way.

This commit also reduces the number of places where the default port
is hard-coded by one.

Fixes: #3345
PR-URL: #3470
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Jul 12, 2016
@bnoordhuis
debugger: propagate --debug-port= to debuggee
74a5e91 
Before this commit `node --debug-port=1234 debug t.js` ignored the
--debug-port= argument, binding to the default port 5858 instead,
making it impossible to debug more than one process on the same
machine that way.

This commit also reduces the number of places where the default port
is hard-coded by one.

Fixes: #3345
PR-URL: #3470
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bnoordhuis