Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http2ServerRequest#setTimeout should return this #33993

Closed
rexagod opened this issue Jun 20, 2020 · 0 comments
Closed

Http2ServerRequest#setTimeout should return this #33993

rexagod opened this issue Jun 20, 2020 · 0 comments

Comments

@rexagod
Copy link
Member

rexagod commented Jun 20, 2020

http2.Http2ServerRequest.setTimeout should return this instead of void/undefined

It's the last thing in the TypeScript typings to fix:

Argument of type 'Http2ServerRequest' is not assignable to parameter of type 'IncomingMessage'.
  The types returned by 'setTimeout(...)' are incompatible between these types.
    Type 'void' is not assignable to type 'IncomingMessage'.ts(2345)

See:

Originally posted by @clshortfuse in #29829 (comment)

@rexagod rexagod changed the title http2.Http2ServerRequest.connection.setTimeout should return this instead of void/undefined http2.Http2ServerRequest.setTimeout should return this instead of void/undefined Jun 20, 2020
@rexagod rexagod changed the title http2.Http2ServerRequest.setTimeout should return this instead of void/undefined Http2ServerRequest#setTimeout should return this Jun 20, 2020
rexagod added a commit to rexagod/node that referenced this issue Jun 20, 2020
codebytere pushed a commit that referenced this issue Jun 27, 2020
Fixes: #33993

PR-URL: #33994
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
codebytere pushed a commit that referenced this issue Jun 30, 2020
Fixes: #33993

PR-URL: #33994
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
addaleax pushed a commit that referenced this issue Sep 22, 2020
Fixes: #33993

PR-URL: #33994
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant