-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: child_process.kill() on windows needs clarification #34858
Comments
I can work on this if you're not willing to submit the PR yourself @s4m0r4m4, would that be okay? |
Totally! I'm haven't contributed to the NodeJS docs before so I'm fine with you doing it! |
Thank you @s4m0r4m4 for your report, amazing, and thank you @joaolucasl for offering to help. Leave a comment if you need help. |
Just opened a PR with an initial paragraph to make this clearer. Let me know with a comment there if you have suggestions :) |
Clarify the inner workings of .kill on Windows, since termination signals are not available there. Fixes: nodejs#34858
Clarify the inner workings of .kill on Windows, since termination signals are not available there. Fixes: nodejs#34858
📗 API Reference Docs Problem
Location
Section of the site where the content exists
Affected URL(s):
Description
Concise explanation of the problem
The NodeJS signals documentation (https://nodejs.org/api/process.html#process_signal_events) is pretty clear that on windows child_process.kill() does NOT actually send the signal, but rather just kills the child process abruptly.
However, the child_process.kill() documentation does not make this clarification, and it's opening sentence ("The subprocess.kill() method sends a signal to the child process. ") leads one to believe that the signal will in fact be sent to the child process on any platform, windows included.
I'd love to just see a quick blurb/sentence that clarifies the behavior on windows vs other platforms (or perhaps just a link pointing to the signals documentation - https://nodejs.org/api/process.html#process_signal_events).
submit a pull request.
The text was updated successfully, but these errors were encountered: