Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failed test: test-fs-watch.js on freebsd10.2 #3541

Closed
jbergstroem opened this issue Oct 27, 2015 · 4 comments
Closed

failed test: test-fs-watch.js on freebsd10.2 #3541

jbergstroem opened this issue Oct 27, 2015 · 4 comments
Labels
freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests.

Comments

@jbergstroem
Copy link
Member

Seems to timeout.

Also, the regression looks recent: https://ci.nodejs.org/computer/iojs-digitalocean-freebsd102-64-2/builds
@jbergstroem jbergstroem added the freebsd Issues and PRs related to the FreeBSD platform. label Oct 27, 2015
@brendanashworth brendanashworth added the test Issues and PRs related to the tests. label Oct 27, 2015
@Trott
Copy link
Member

Trott commented Oct 27, 2015

Everything starting at line 130 was added in 87e820e. I propose moving that content to its own file, as it is essentially an independent test. Then we can watch subsequent CI tests and see if it fails in that bit of code or in the previously existing code.

@Trott Trott mentioned this issue Oct 27, 2015
Closed
Trott added a commit that referenced this issue Oct 28, 2015
@Trott
test: split independent tests into separate files
26e47ef 
Move ENOENT related tests out of general fs.watch() test file and into
its own file. This may help diagnose
#3541.

PR-URL: #3548
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
rvagg pushed a commit to rvagg/io.js that referenced this issue Oct 29, 2015
@Trott @rvagg
test: split independent tests into separate files
74e2328 
Move ENOENT related tests out of general fs.watch() test file and into
its own file. This may help diagnose
nodejs#3541.

PR-URL: nodejs#3548
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@saper saper mentioned this issue Oct 29, 2015
Closed
Trott added a commit that referenced this issue Oct 30, 2015
@Trott @jasnell
test: split independent tests into separate files
1c169a0 
Move ENOENT related tests out of general fs.watch() test file and into
its own file. This may help diagnose
#3541.

PR-URL: #3548
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Trott added a commit that referenced this issue Oct 30, 2015
@Trott @jasnell
test: split independent tests into separate files
c563a34 
Move ENOENT related tests out of general fs.watch() test file and into
its own file. This may help diagnose
#3541.

PR-URL: #3548
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@Fishrock123
Copy link
Contributor

Any update on this? has it continued after split up?

@Trott
Copy link
Member

Trott commented Nov 2, 2015

After the split up, neither test has failed. Which is weird because one of them should have continued failing. So maybe it's some oddball filesystem interaction between the two tests that only manifests on FreeBSD? Or maybe there's been some change in the FreeBSD build that fixed things? I don't know.

I'm comfortable closing this unless/until some issue starts to manifest itself again. And I'm comfortable leaving it open as a marker that something strange and unexplained is going on. Either way...

@jbergstroem
Copy link
Member Author

This is a new slave in CI which is why I was a bit more trigger happy to report it (hoping for increased visibility). Happy to close and reopen if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jbergstroem @Trott @Fishrock123 @brendanashworth