-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage report left in comments is "noisy" #35696
Comments
Could we change the comment content to put it in a |
I didn't see a way to do this in the configuration. @thomasrockhu is there a way to customize the coverage report, so that some of the information is hidden under a |
Maybe also skip draft PR. Pretty annoying in such case. |
We could also skip coverage for doc-only changes like we do with the asan workflow: node/.github/workflows/test-asan.yml Lines 13 to 14 in c55f661
|
@bcoe, I don't believe that's possible, but that's really good feedback. I'll bring it to the product team to see what we can do here, but I'm not sure what the turnaround time would be. What's the ideal result for you? @gengjiawen, also great feedback. Thanks for bringing this up! |
@thomasrockhu Ideally, something like that: Merging #35670 into master will decrease coverage by
|
Impacted Files | Coverage Δ | |
---|---|---|
src/node_i18n.cc | 76.00% <0.00%> (ø) |
|
src/inspector/worker_inspector.cc | 95.52% <0.00%> (ø) |
|
src/node.h | 93.33% <0.00%> (ø) |
|
src/inspector_agent.h | 87.50% <0.00%> (ø) |
|
src/inspector/node_string.cc | 54.28% <0.00%> (ø) |
|
src/api/hooks.cc | 80.18% <0.00%> (ø) |
|
src/env.cc | 87.19% <0.00%> (ø) |
|
src/node_contextify.h | 70.83% <0.00%> (ø) |
|
src/inspector/worker_agent.cc | 89.61% <0.00%> (ø) |
|
src/node_os.cc | 75.63% <0.00%> (ø) |
|
... and 264 more |
The most relevant info is still available at a glance, and it doesn't take forever to scroll by.
@aduh95, awesome, we'll look into making this configurable in the yaml. Thanks again for the feedback! |
Collect Windows and C++ coverage. Configure codecov so that comments are more concise and are only left when coverage varies. PR-URL: #35670 Fixes: #35696 Refs: #35653 Refs: #35646 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Collect Windows and C++ coverage. Configure codecov so that comments are more concise and are only left when coverage varies. PR-URL: #35670 Fixes: #35696 Refs: #35653 Refs: #35646 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Collect Windows and C++ coverage. Configure codecov so that comments are more concise and are only left when coverage varies. PR-URL: #35670 Fixes: #35696 Refs: #35653 Refs: #35646 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Problem
I noticed on a couple PRs, that the coverage comment left by codecov.io was hidden.
I'm guessing that part of why folks wanted to hide this notification, is that it takes up a lot of screen space on the PR 👇
Proposed Solution
I have a PR open here that:
What if folks still aren't happy with the report?
If folks are still finding they find coverage a little bit noisy (and are inclined to hide the comment), we can turn off the comments in configuration.
@nodejs/testing
The text was updated successfully, but these errors were encountered: