-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Add issue reference to the PR template #36338
Comments
Hey. :) Step 4 of the commit message guidelines already states that if the patch fixes an issue, it can be referenced at the end of the commit message body using the full URL. When a PR is opened, the commit message body of the first commit is automatically prepended to the PR template. Adding a field for the referenced issue in the PR template would require a manual removal of it because the PR body already contains the link to the referenced issue. So, do you still think it is necessary? |
Hi :), Maybe input from other people as well would be helpful in this. |
The PR template should include a Reference isssue (Fixes #issue_number) so the PR can be tracked back to the issue easily.For a beginner trying to read PRs to become comfortable with the codebase,it is really helpful if one can directly reach the issue the PR fixes. Fixes: nodejs#36338
The PR template should include a Reference isssue (Fixes #issue_number) so the PR can be tracked back to the issue easily.For a beginner trying to read PRs to become comfortable with the codebase,it is really helpful if one can directly reach the issue the PR fixes. Fixes: #36338 PR-URL: #36440 Reviewed-By: James M Snell <jasnell@gmail.com>
The PR template should include a Reference isssue (Fixes #issue_number) so the PR can be tracked back to the issue easily.For a beginner trying to read PRs to become comfortable with the codebase,it is really helpful if one can directly reach the issue the PR fixes. Fixes: #36338 PR-URL: #36440 Reviewed-By: James M Snell <jasnell@gmail.com>
Affected URL(s):
Description
✍️
The PR template should include a
Reference isssue (Fixes #issue_number)
so the the PR can be tracked back to the issue easily. For a beginner trying to read PRs to become comfortable with the codebase, it is really helpful if one can directly reach the issue the PR fixes.submit a pull request.
The text was updated successfully, but these errors were encountered: