Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: code example contains errors in crypto api #38540

Closed
1 task done
JBaczuk opened this issue May 4, 2021 · 0 comments · Fixed by #38542 or javascript-indonesias/node#357
Closed
1 task done

doc: code example contains errors in crypto api #38540

JBaczuk opened this issue May 4, 2021 · 0 comments · Fixed by #38542 or javascript-indonesias/node#357
Labels
doc Issues and PRs related to the documentations.

Comments

@JBaczuk
Copy link
Contributor

JBaczuk commented May 4, 2021

📗 API Reference Docs Problem

  • Version: 16.1.0
  • Platform: N/A
  • Subsystem: crypto

Location

Section of the site where the content exists

Affected URL(s):

Description

Concise explanation of the problem

const {
  createECDH,
  createHash,
} = await crypto('crypto');

Should be

const {
  createECDH,
  createHash,
} = await import('crypto');

  • I would like to work on this issue and
    submit a pull request.
@JBaczuk JBaczuk added the doc Issues and PRs related to the documentations. label May 4, 2021
JBaczuk added a commit to JBaczuk/node that referenced this issue May 4, 2021
JBaczuk added a commit to JBaczuk/node that referenced this issue May 5, 2021
@Trott Trott closed this as completed in aed17e9 May 6, 2021
targos pushed a commit that referenced this issue May 17, 2021
Fixes: #38540
PR-URL: #38542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
1 participant