Install directory permissions broken on non-English Windows systems #39224

DvdGiessen · 2021-07-01T16:03:44Z

Version: 16.4.1
Platform: Windows

What steps will reproduce the bug?

Install Node v16.4.1 on a non-English Windows system.

How often does it reproduce? Is there a required condition?

It always reproduces as far as I can tell.

What do you see?

Additional information

I presume this bug was introduced in e817ba7.

Core issue seems to be that Windows localizes names of built-in users and groups. On my non-English Windows system, there does not exist a group called "Authenticated Users". It exists using a localized name. Hence, the solution implemented in that commit will never work on non-English Windows systems.

Instead, we should probably use a SID to reference the correct group. See https://support.microsoft.com/kb/243330.

EDIT: Presumably also affects v14.17.2 and v12.22.2, as these seem to include this same change. Haven't checked.

EDIT2: To clarify; this completely breaks Node.js installs, make it unable to complete installation, and when upgrading will leave Node.js in a broken state.

The text was updated successfully, but these errors were encountered:

ghost · 2021-07-01T17:24:46Z

Similar. Cannot upgrade from 14.17.1 to 14.17.2

gusbarzi · 2021-07-01T18:21:57Z

I also have the same problem, could you help me

Theraa0 · 2021-07-01T19:26:45Z

Also just encountered this issue. Neither the long term support, nor the latest version work and give the same error message as in the images shared by DvdGiessen and web2933.

striezel · 2021-07-01T20:54:28Z

EDIT: Presumably also affects v14.17.2 and v12.22.2, as these seem to include this same change. Haven't checked.

For what it's worth: I encountered the same issue when trying to upgrade from 14.17.1 LTS to 14.17.2 LTS, x64 version of the installer. Operating system is Windows 10 Home Edition, version 20H2, 64 bit. Language is German.

Just making a guess here, but the problem may be related to commit d0b449d which includes a fix for "CVE-2021-22921: Windows installer - Node Installer Local Privilege Escalation (Medium)". At least that is the only change mentioned in the changelog for 14.17.2 and 16.4.1 that references installation on Windows systems.

RamiroPastor · 2021-07-01T22:08:10Z

Same problem here with both msi installers (32 and 64 bit) and Windows in spanish

cecilemuller · 2021-07-01T23:01:58Z

I can confirm it must be a recent change: 16.4.0 and older still work, only 16.4.1 produces this issue.

ThadeuFerreira · 2021-07-02T01:53:32Z

Is it possible to download the bug free version?

Or is there any workaround?

Ayase-252 · 2021-07-02T02:11:14Z

@ThadeuFerreira

How about using https://github.com/coreybutler/nvm-windows to install Node.js?

Lem0nRavioli · 2021-07-02T04:24:04Z

EDIT: Presumably also affects v14.17.2 and v12.22.2, as these seem to include this same change. Haven't checked.

Thinking about that, i could bypass this error by installing a previous release: https://nodejs.org/download/release/v14.17.1/

cecilemuller · 2021-07-02T04:46:26Z

@ThadeuFerreira
Is it possible to download the bug free version?

The old versions are still available, for example:
https://nodejs.org/dist/v16.4.0/node-v16.4.0-x64.msi

RubenFilipe07 · 2021-07-02T05:47:14Z

I got the same problem when trying to install the x64 versions 4.17.2 LTS and 16.4.1 on Windows 10 Home Single Language (21H1) (Brazilian Portuguese). But I managed to install normally the 4.17.1 version that I downloaded at: https://nodejs.org/dist/v14.17.1/node-v14.17.1-x64.msi

targos · 2021-07-02T05:56:20Z

/cc @kumarak @nodejs/platform-windows

And @nodejs/releasers because I think we'll want to publish a new release as soon as this is fixed.

peterterbe · 2021-07-02T12:10:31Z

A stupid workaround is to create a user called "Authenticated Users". The new user can be removed right after the setup. 🤦

Griha3212 · 2021-07-02T12:36:59Z

Installed 16.4.0 for now. Awaiting a fix.

cyrelk · 2021-07-02T13:01:48Z

I confirm, both 14.17.2 and 16.4.1 are unable to install on a French windows 10 system due to the lack of an 'Authenticated Users' group.

szabb · 2021-07-02T13:05:25Z

I confirm, both 14.17.2 and 16.4.1 are unable to install on a French windows 10 system due to the lack of an 'Authenticated Users' group.

same with Hungarian windows

Eduardo-Carregoza · 2021-07-02T15:13:05Z

Hello, really the problem was solved when creating the user "Authenticated Users", however, in my case, I needed to install node via command line with chocolatey.

inzanty · 2021-07-02T16:14:58Z

Confirm too on Windows 7 (Russian Version).

shal-ae · 2021-07-02T16:22:30Z

I've spent a day trying to install 14.17.2. I even reinstalled windows with no result. I think it is a bad idea to keep it updated

BethGriggs · 2021-07-02T16:41:13Z

The problem does appear to have been introduced in e817ba7 (fix for CVE-2021-22921) on non-English Windows. There are a few folks investigating the issue. Once an amended patch is available we will issue a new release for each release line.

mathiasdg · 2021-07-04T12:56:58Z

same problem here

RaulSMelo · 2021-07-04T23:32:43Z

Em sistemas Windows que não sejam em inglês, isso pode ser resolvido usando um único comando como Administrador. Processo completo abaixo:

Inicie o cmd como Administrador

Digite net localgroup /add "Authenticated Users"e pressione Enter

Instale ou atualize o Node.js para a versão 14.17.2

No entanto, este é um bug: o instalador deve ser corrigido.

Muito obrigado !! Funcionou muito bem a instalação com essa linha de comando

RaulSMelo · 2021-07-04T23:44:04Z

Muito OBRIGADOOO !!! Excelente dica.

alexthe2 · 2021-07-05T08:26:33Z

I had the same issue yesterday and "installed" it via binaries, added to path and run installer.bat

Well known user account names are localized on Windows. Look up the "Authenticated Users" user by its security identifier to get the localized name. PR-URL: nodejs#39241 Fixes: nodejs#39224 Refs: nodejs@e817ba7 Refs: https://hackerone.com/reports/1211160 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>

Well known user account names are localized on Windows. Look up the "Authenticated Users" user by its security identifier to get the localized name. PR-URL: #39241 Fixes: #39224 Refs: e817ba7 Refs: https://hackerone.com/reports/1211160 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>

revzo · 2021-07-05T13:50:13Z

Megerősítem, hogy a 14.17.2 és a 16.4.1 egyaránt nem tud telepíteni egy francia Windows 10 rendszerre a „Hitelesített felhasználók” csoport hiánya miatt.

ugyanez a magyar ablakokkal

Ne is mondd, kiégek....mire rájöttem mi a gond:D

revzo · 2021-07-05T13:52:42Z

node-v16.4.0-x64 : working
node-v16.4.1-x64 : NOT working

Shady-ops · 2021-07-05T14:03:31Z

Run the command prompt as an administrator and ctrl+c/ctrl+v:
net localgroup /add "Authenticated Users"
Then click retry or run the installation file again

Didier68 · 2021-07-05T14:58:17Z

Same problem with 14.17.2 LTS !
Resolved by using a previous package from https://nodejs.org/dist/v14.17.0/

st4rl0rd · 2021-07-05T15:13:12Z

https://exerror.com/an-error-occurred-while-applying-security-settings-authenticated-users-is-not-a-valid-user-or-group-in-nodejs-windows/

Eliaxs1900 · 2021-07-05T15:20:38Z

Authenticated Users

Hello, really the problem was solved when creating the user "Authenticated Users", however, in my case, I needed to install node via command line with chocolatey.

You are right @Eduardo-Carregoza,
Now i have successfully installed Node 16.4.1

Thanks 👌🏽

richardlau · 2021-07-05T15:22:38Z

👋 The release team are aiming to get releases out later today to fix the regression with the Windows installer. I suggest folks wait for those, rather than create dummy users.

Trott · 2021-07-05T16:44:04Z

Fixed releases for 12.x and 14.x are out. Waiting on 16.x but shouldn't be too long.

ghost · 2021-07-05T16:53:46Z

https://nodejs.org/dist/v14.17.3/node-v14.17.3-x64.msi - successfully installed ✔

BethGriggs · 2021-07-05T17:51:20Z

The regression was introduced in v12.22.2, v14.17.2, and v16.4.1.

The fix (#39241) has been released in v12.22.3, v14.17.3, and v16.4.2. If you hit this issue, the solution is to upgrade to one of these versions.

Orgelnisten · 2021-07-05T17:59:08Z

16.4.2 is now available, and works on non english systems!

Well known user account names are localized on Windows. Look up the "Authenticated Users" user by its security identifier to get the localized name. PR-URL: nodejs#39241 Fixes: nodejs#39224 Refs: nodejs@e817ba7 Refs: https://hackerone.com/reports/1211160 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>

kriskris79 · 2022-09-30T20:05:56Z

@ThadeuFerreira

How about using https://github.com/coreybutler/nvm-windows to install Node.js?

It works thanks Thadeu

targos added install Issues and PRs related to the installers. windows Issues and PRs related to the Windows platform. labels Jul 1, 2021

striezel mentioned this issue Jul 1, 2021

Installation on Windows 10 Education failed #39226

Closed

Ayase-252 mentioned this issue Jul 2, 2021

Error: Users is not a valid user or group nodejs/help#3436

Closed

kamtschatka mentioned this issue Jul 2, 2021

--create_source_map throws exception on windows when using input source maps and chunks google/closure-compiler#3840

Closed

targos mentioned this issue Jul 2, 2021

Failed to install node v14.17.2 on PTB language Windows system. #39233

Closed

This was referenced Jul 2, 2021

Install issue nodejs/help#3439

Closed

Help! Please. #39234

Closed

Ayase-252 added the confirmed-bug Issues with confirmed bugs. label Jul 2, 2021

BethGriggs pinned this issue Jul 2, 2021

vsemozhetbyt mentioned this issue Jul 4, 2021

Install problem nodejs/help#3452

Closed

richardlau closed this as completed in e9cf120 Jul 5, 2021

richardlau reopened this Jul 5, 2021

richardlau mentioned this issue Jul 5, 2021

_Authenticated user is not a valid user or group_ error message during installation nodejs/help#3456

Closed

This was referenced Jul 5, 2021

Node.js setup - Authenticated User is not valid #39274

Closed

Installation Error #39275

Closed

BethGriggs closed this as completed Jul 5, 2021

Trott unpinned this issue Jul 11, 2021

Install directory permissions broken on non-English Windows systems #39224

Install directory permissions broken on non-English Windows systems #39224

Comments

DvdGiessen commented Jul 1, 2021 • edited Loading

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What do you see?

Additional information

ghost commented Jul 1, 2021

gusbarzi commented Jul 1, 2021

Theraa0 commented Jul 1, 2021

striezel commented Jul 1, 2021 • edited Loading

RamiroPastor commented Jul 1, 2021

cecilemuller commented Jul 1, 2021 • edited Loading

ThadeuFerreira commented Jul 2, 2021

Ayase-252 commented Jul 2, 2021

Lem0nRavioli commented Jul 2, 2021

cecilemuller commented Jul 2, 2021

RubenFilipe07 commented Jul 2, 2021

targos commented Jul 2, 2021

peterterbe commented Jul 2, 2021

Griha3212 commented Jul 2, 2021

cyrelk commented Jul 2, 2021

szabb commented Jul 2, 2021

Eduardo-Carregoza commented Jul 2, 2021

inzanty commented Jul 2, 2021 • edited Loading

shal-ae commented Jul 2, 2021

BethGriggs commented Jul 2, 2021

mathiasdg commented Jul 4, 2021

RaulSMelo commented Jul 4, 2021

RaulSMelo commented Jul 4, 2021

alexthe2 commented Jul 5, 2021

revzo commented Jul 5, 2021

revzo commented Jul 5, 2021

Shady-ops commented Jul 5, 2021

Didier68 commented Jul 5, 2021 • edited Loading

st4rl0rd commented Jul 5, 2021

Eliaxs1900 commented Jul 5, 2021

richardlau commented Jul 5, 2021

Trott commented Jul 5, 2021

ghost commented Jul 5, 2021

BethGriggs commented Jul 5, 2021

Orgelnisten commented Jul 5, 2021

kriskris79 commented Sep 30, 2022

DvdGiessen commented Jul 1, 2021 •

edited

Loading

striezel commented Jul 1, 2021 •

edited

Loading

cecilemuller commented Jul 1, 2021 •

edited

Loading

inzanty commented Jul 2, 2021 •

edited

Loading

Didier68 commented Jul 5, 2021 •

edited

Loading