Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update nghttp2 to v1.45.1 #39449

Closed
targos opened this issue Jul 19, 2021 · 5 comments
Closed

update nghttp2 to v1.45.1 #39449

targos opened this issue Jul 19, 2021 · 5 comments
Labels
dependencies Pull requests that update a dependency file. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. http2 Issues or PRs related to the http2 subsystem.

Comments

@targos
Copy link
Member

targos commented Jul 19, 2021 •
edited
Loading

https://github.com/nghttp2/nghttp2/releases/tag/v1.45.1

We are currently at v1.42.0.

@nodejs/http2
@targos targos added help wanted Issues that need assistance from volunteers or PRs that need help to proceed. http2 Issues or PRs related to the http2 subsystem. dependencies Pull requests that update a dependency file. labels Jul 19, 2021
@mcollina
Copy link
Member

cc @jasnell

@targos targos changed the title update nghttp2 to v1.44.0 update nghttp2 to v1.45.0 Sep 20, 2021
@targos
Copy link
Member Author

targos commented Sep 20, 2021

v1.45.0 was released today

@targos targos changed the title update nghttp2 to v1.45.0 update nghttp2 to v1.45.1 Sep 21, 2021
@thunder-coding
Copy link
Contributor

According to https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#dependencies, PRs for dependencies won't be accepted but this issue seems to have a help wanted label. So, will my PR be accepted if I fix this?

@mcollina
Copy link
Member

Version updates are just about the only thing accepted, send it over!

thunder-coding added a commit to thunder-coding/node that referenced this issue Sep 24, 2021
@thunder-coding
deps: Update nghttp2 to v1.45.1
565ae48 
Fixes nodejs#39449
thunder-coding added a commit to thunder-coding/node that referenced this issue Sep 24, 2021
@thunder-coding
deps: Update nghttp2 to v1.45.1
2058eba 
Fixes nodejs#39449
@thunder-coding thunder-coding mentioned this issue Sep 24, 2021
Closed
@gengjiawen
Copy link
Member

#40206 landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: Update nghttp2 to v1.45.1 thunder-coding/node
4 participants
@mcollina @targos @gengjiawen @thunder-coding